You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/03/22 04:47:37 UTC
Review Request 73248: ATLAS-4219 : Basic Search : Search with
Glossary term returning approximate count as -1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73248/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4219
https://issues.apache.org/jira/browse/ATLAS-4219
Repository: atlas
Description
-------
Searching with Glossary term returns approximate count as -1 in response.
Without Term it returns proper approximate count.
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java d9db9bf8b
Diff: https://reviews.apache.org/r/73248/diff/1/
Testing
-------
Approximate count will be same regardless of any filters or limit/offset
Precommit :
Thanks,
Pinal Shah
Re: Review Request 73248: ATLAS-4219 : Basic Search : Search with
Glossary term returning approximate count as -1
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73248/#review222726
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On March 21, 2021, 11:04 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73248/
> -----------------------------------------------------------
>
> (Updated March 21, 2021, 11:04 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4219
> https://issues.apache.org/jira/browse/ATLAS-4219
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Searching with Glossary term returns approximate count as -1 in response.
>
> Without Term it returns proper approximate count.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java d9db9bf8b
>
>
> Diff: https://reviews.apache.org/r/73248/diff/1/
>
>
> Testing
> -------
>
> Approximate count will be same regardless of any filters or limit/offset
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/462/console
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73248: ATLAS-4219 : Basic Search : Search with
Glossary term returning approximate count as -1
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73248/
-----------------------------------------------------------
(Updated March 22, 2021, 6:04 a.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4219
https://issues.apache.org/jira/browse/ATLAS-4219
Repository: atlas
Description
-------
Searching with Glossary term returns approximate count as -1 in response.
Without Term it returns proper approximate count.
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java d9db9bf8b
Diff: https://reviews.apache.org/r/73248/diff/1/
Testing (updated)
-------
Approximate count will be same regardless of any filters or limit/offset
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/462/console
Thanks,
Pinal Shah