You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/12/07 22:42:43 UTC
Re: Review Request 39923: Cleaned up configuration.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review109192
-----------------------------------------------------------
What is the status of this patch -- can someone (Till) commit it?
- Neil Conway
On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 12:20 a.m.)
>
>
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Edited configuration.md for style and consistency. Made consistent use of <code></code> for commands, flags, and flag values. Edited the libprocess flags for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or not the directory is an optional parameter. Note that the libprocess `--with-*` flags have two different descriptions depending upon whether or not the library is bundled with Mesos.
>
>
> Diffs
> -----
>
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
>
> Diff: https://reviews.apache.org/r/39923/diff/
>
>
> Testing
> -------
>
> Viewed with the mesos website container (https://github.com/mesosphere/mesos-website-container).
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39923: Cleaned up configuration.md.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote:
> > What is the status of this patch -- can someone (Till) commit it?
Looks like this is in need of a rebase, I'll update it.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review109192
-----------------------------------------------------------
On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 12:20 a.m.)
>
>
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Edited configuration.md for style and consistency. Made consistent use of <code></code> for commands, flags, and flag values. Edited the libprocess flags for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or not the directory is an optional parameter. Note that the libprocess `--with-*` flags have two different descriptions depending upon whether or not the library is bundled with Mesos.
>
>
> Diffs
> -----
>
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
>
> Diff: https://reviews.apache.org/r/39923/diff/
>
>
> Testing
> -------
>
> Viewed with the mesos website container (https://github.com/mesosphere/mesos-website-container).
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39923: Cleaned up configuration.md.
Posted by Till Toenshoff <to...@me.com>.
> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote:
> > What is the status of this patch -- can someone (Till) commit it?
>
> Greg Mann wrote:
> Looks like this is in need of a rebase, I'll update it.
Sry, did not have it on my radar -- it's always a good idea to add me as a reviewer for preventing this :).
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review109192
-----------------------------------------------------------
On Jan. 5, 2016, 6:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 6:52 p.m.)
>
>
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Edited configuration.md for style and consistency. Made consistent use of <code></code> for commands, flags, and flag values. Edited the libprocess flags for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or not the directory is an optional parameter. Note that the libprocess `--with-*` flags have two different descriptions depending upon whether or not the library is bundled with Mesos.
>
>
> Diffs
> -----
>
> docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d
>
> Diff: https://reviews.apache.org/r/39923/diff/
>
>
> Testing
> -------
>
> Viewed with the mesos website container (https://github.com/mesosphere/mesos-website-container).
>
>
> Thanks,
>
> Greg Mann
>
>