[GitHub] [accumulo] jzgithub1 commented on a change in pull request #1422: Fixes #1225 - Created a single ZooNode that tracks changes for all table configs

[GitBox <gi...@apache.org>]

jzgithub1 commented on a change in pull request #1422: Fixes #1225 - Created a single ZooNode that tracks changes for all table configs
URL: https://github.com/apache/accumulo/pull/1422#discussion_r345795491
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java
 ##########
 @@ -148,14 +159,20 @@ private ZooKeeper getZooKeeper() {
   }
 
   private class ZCacheWatcher implements Watcher {
+
     @Override
     public void process(WatchedEvent event) {
       if (log.isTraceEnabled()) {
         log.trace("{}", event);
       }
+      setWatcherForTableConfigVersion(event);
 
 Review comment:
   I see what you are saying but unfortunately I don't have way to obtain the Accumulo Instance ID in the ZooCache constructor.   The zoopath of any event that occurs will have the Instance Id in it which I can 'regex out'.   I also am sure that ZooKeeper is connected and functioning by setting the watcher for the 'table-config-version' znode at this point in execution.  
   
   I looked hard for alternatives to doing it this way.  Trust me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services