You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jayachandrakasarla (via GitHub)" <gi...@apache.org> on 2026/06/18 07:04:59 UTC

[PR] added code to render lighter shade on badge based on the saved note [airflow]

jayachandrakasarla opened a new pull request, #68701:
URL: https://github.com/apache/airflow/pull/68701

   Closes #68615 
   
   Modified the `GridTi.tsx` file to render the task instance badge with a lighter shade to indicate a saved note.
   
   Here's how it looks like in the Airflow 3 UI:
   
   <img width="561" height="237" alt="image" src="https://github.com/user-attachments/assets/71b104f2-d07d-455f-9f2c-c90546d1bc56" />
   <img width="604" height="223" alt="image" src="https://github.com/user-attachments/assets/051ea194-ce96-4b27-a215-51bdb3e2d4d1" />
   
   
   I've added the following line at the top of `GridTI.tsx` file to style the badge when a note is available and I don't think it should be hardcoded in this file, please let me know if you want me to move it to some other file.
   ```tsx
   const NOTE_GRADIENT = "linear-gradient(45deg, var(--chakra-colors-color-palette-solid) 65%, var(--chakra-colors-color-palette-emphasized) 65%)";```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render Note indicator in Airflow 3 Grid view [airflow]

Posted by "jayachandrakasarla (via GitHub)" <gi...@apache.org>.
jayachandrakasarla commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4739006301

   @bbovenzi I've added the following line at the top of `GridTI.tsx` file to style the badge when a note is available.
   ```tsx
   const NOTE_GRADIENT = "linear-gradient(45deg, var(--chakra-colors-color-palette-solid) 65%, var(--chakra-colors-color-palette-emphasized) 65%)";
   ```
   
    I don't think it's a good idea to hardcode it in this file, please let me know if I should move it to some other file. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "jayachandrakasarla (via GitHub)" <gi...@apache.org>.
jayachandrakasarla commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4751337847

   @pierrejeambrun @choo121600 @ryanahamilton @vatsrahul1001 Could you please review this PR? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "eitan-shalev (via GitHub)" <gi...@apache.org>.
eitan-shalev commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4767731045

   This PR addresses the task-instance level notes. What would it take to implement this on dag-run level notes as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4808431293

   Closing in favor of https://github.com/apache/airflow/pull/68979
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "jayachandrakasarla (via GitHub)" <gi...@apache.org>.
jayachandrakasarla commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4790933837

   @pierrejeambrun agreed. I tried checking if there are any other ways to pull the details of a saved note but I couldn't find a shared context/props that are being passed down to the grid view component that provides a list of saved notes.
   
   Do you have any suggestions to find out about the saved notes? 
   
   I’m not sure if this is allowed, but do you think having an API endpoint that fetches all saved task instance notes for a DAG run in JSON format would be a better approach in this case? It would be very helpful since we would only need to make one request per DAG run.
   
   An even better option might be an API endpoint that returns the saved note data for all DAG runs of a DAG in a single request, which we could then use directly.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4791159801

   We could add the note back to the grid response directly, so we have that information right away. (and that's a UI endpoint so we're free to modify it). 
   
   But we would nee to make sure that this is not slowing down the grid endpoints.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "jayachandrakasarla (via GitHub)" <gi...@apache.org>.
jayachandrakasarla commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4792056182

   That makes sense, I'll work on it tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "jayachandrakasarla (via GitHub)" <gi...@apache.org>.
jayachandrakasarla commented on PR #68701:
URL: https://github.com/apache/airflow/pull/68701#issuecomment-4797900180

   @pierrejeambrun I have raised another pull request with both UI and API changes #68979, please review it.
   
   Once reviewed, I'll close this current PR and work on that if any changes are requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Render saved note indicator in Airflow 3 Grid View UI [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #68701: Render saved note indicator in Airflow 3 Grid View UI
URL: https://github.com/apache/airflow/pull/68701


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org