[GitHub] [airflow] kimyen commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

[GitBox <gi...@apache.org>]

kimyen commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-920335723


   One of the unit test failed:
   ```
   ==== Helm sqlite: 2 failures ====
   
   chart/tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_1: AssertionError: assert {'mountPath':...name': 'logs'} == {'mountPath':...'airflow.cfg'}
     Differing items:
     {'name': 'logs'} != {'name': 'config'}
     {'mountPath': '/opt/airflow/logs'} != {'mountPath': '/opt/airflow/airflow.cfg'}
     Right contains 2 more items:
     {'readOnly': True, 'subPath': 'airflow.cfg'}
     Use -v to get the full diff
   chart/tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_2: AssertionError: assert {'mountPath':...name': 'logs'} == {'mountPath':...'airflow.cfg'}
     Differing items:
     {'name': 'logs'} != {'name': 'config'}
     {'mountPath': '/opt/airflow/logs'} != {'mountPath': '/opt/airflow/airflow.cfg'}
     Right contains 2 more items:
     {'readOnly': True, 'subPath': 'airflow.cfg'}
     Use -v to get the full diff
   Error: Process completed with exit code 1.
   ```
   
   I want to challenge the value of this test. It doesn't seem to catch anything that would break the `webserver` deployment, but rather being picky about the order of the volume. 😞 
   
   I would expect to break a test that has a set of volumes that the webserver deployment should have, and with this PR, extend the test to add the new volume. I don't know enough to write such a test. What do you think about the proposal? Does such test already exist (if so, it didn't fail)? Can I get some pointers on how to write the test I propose?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org