You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jonathan Allen (JIRA)" <ji...@apache.org> on 2015/07/27 19:55:06 UTC
[jira] [Updated] (HADOOP-10544) Find command - add operator
functions to find command
[ https://issues.apache.org/jira/browse/HADOOP-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Allen updated HADOOP-10544:
------------------------------------
Attachment: HADOOP-10544.patch
ooops, made most of the changes some time ago and then forgot about them.
bq. With the patch, the command will throw IllegalArgumentException If the first expression is wrong. On the other hand, the command will throw IOException if another argument is wrong.
The Javadoc for the superclass says it should throw IOException so I've made it consistently that.
bq. "passing" should be "failing".
Fixed.
bq. Would you document the precedence of the operators?
Just realised I haven't done this yet. I'll try to get it done this evening.
bq. Would you please add test cases for Not to TestHDFSConf.xml?
Test added.
{quote}Would you validate the number of arguments in addChildren/addArguments and throw IllegalArgumentException when the number of arguments is wrong?
{quote}
Still to do.
{quote}
In addition, would you validate
the number of '(' matches the number of ')',
and the number of ')' does not exceed the number of '(' at any point?
{quote}
Validation added.
> Find command - add operator functions to find command
> -----------------------------------------------------
>
> Key: HADOOP-10544
> URL: https://issues.apache.org/jira/browse/HADOOP-10544
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jonathan Allen
> Assignee: Jonathan Allen
> Priority: Minor
> Labels: BB2015-05-TBR
> Attachments: HADOOP-10544.patch, HADOOP-10544.patch, HADOOP-10544.patch, HADOOP-10544.patch, HADOOP-10544.patch, HADOOP-10544.patch
>
>
> Add operator functions (OR, NOT) to the find command created under HADOOP-8989.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)