You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/07/11 13:53:34 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24661: fix: Ensure config is a dict in cross filters scope migration
codecov[bot] commented on PR #24661:
URL: https://github.com/apache/superset/pull/24661#issuecomment-1630878031
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24661](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (94ad77b) into [master](https://app.codecov.io/gh/apache/superset/commit/c53b2499988b5aeec96b1064f86703a3891e0efc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c53b249) will **decrease** coverage by `0.01%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 94ad77b differs from pull request most recent head 421dece. Consider uploading reports for the commit 421dece to get more accurate results
```diff
@@ Coverage Diff @@
## master #24661 +/- ##
==========================================
- Coverage 68.97% 68.96% -0.01%
==========================================
Files 1907 1907
Lines 74153 74153
Branches 8182 8177 -5
==========================================
- Hits 51148 51141 -7
- Misses 20882 20892 +10
+ Partials 2123 2120 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `79.47% <ø> (?)` | |
| postgres | `79.55% <ø> (-0.01%)` | :arrow_down: |
| presto | `54.04% <ø> (+<0.01%)` | :arrow_up: |
| python | `83.30% <ø> (-0.03%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.83% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hart-echarts/src/MixedTimeseries/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3RyYW5zZm9ybVByb3BzLnRz) | `0.78% <ø> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `0.00% <ø> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `9.09% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `46.96% <0.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `69.76% <0.00%> (ø)` | |
| [...features/annotationLayers/AnnotationLayerModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2Fubm90YXRpb25MYXllcnMvQW5ub3RhdGlvbkxheWVyTW9kYWwudHN4) | `58.97% <ø> (ø)` | |
| [...ntend/src/features/annotations/AnnotationModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2Fubm90YXRpb25zL0Fubm90YXRpb25Nb2RhbC50c3g=) | `50.98% <ø> (ø)` | |
| [...end/src/features/cssTemplates/CssTemplateModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2Nzc1RlbXBsYXRlcy9Dc3NUZW1wbGF0ZU1vZGFsLnRzeA==) | `56.09% <ø> (ø)` | |
| [superset/datasets/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `100.00% <ø> (ø)` | |
| [superset/examples/birth\_names.py](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `70.00% <ø> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/superset/pull/24661?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24661/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org