Re: [PR] Address logging warnings [solr]

["psalagnac (via GitHub)" <gi...@apache.org>]

psalagnac commented on PR #4420:
URL: https://github.com/apache/solr/pull/4420#issuecomment-4718600341

   > LGTM. Interesting to see how much nicer the formatting is with the new pattern. I hope this covers all places in Solr? Also, how do we ensure this doesn't come back?
   
   Such bad formats are supposed to be reject by pre-commit checks, but here there were ignored because of `// nowarn` annotation comments.
   
   Unfortunately I don't think we can prevent some checks to be explicitly ignored.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org