You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Michael Starch (JIRA)" <ji...@apache.org> on 2013/01/29 21:09:13 UTC
[jira] [Updated] (OODT-553) Update
org.apache.oodt.commons.exec.EnvUtilities to Use System.getEnvironment
[ https://issues.apache.org/jira/browse/OODT-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Starch updated OODT-553:
--------------------------------
Attachment: OODT-553.patch.2013-01-29.txt
This is a proposed patch.
It uses System.getEnvironment() (instead of exec "env"). The test cases (additional) will only run on UNIX systems because they require USER and HOME environment variables to be set.
Could another user review it? I am new.
Enjoy!
> Update org.apache.oodt.commons.exec.EnvUtilities to Use System.getEnvironment
> -----------------------------------------------------------------------------
>
> Key: OODT-553
> URL: https://issues.apache.org/jira/browse/OODT-553
> Project: OODT
> Issue Type: Improvement
> Components: commons
> Reporter: Michael Starch
> Priority: Minor
> Fix For: 0.6
>
> Attachments: OODT-553.patch.2013-01-29.txt
>
>
> The environment variables utilities use a command line invocation of 'env' to get the environment variables due to the fact that java 1.4 did not have a System.getEnvironment call.
> This is no longer the best solution (and is suspected of causing some errors).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (OODT-553) Update
org.apache.oodt.commons.exec.EnvUtilities to Use System.getEnvironment
Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
Thanks Mike feel free to use http://reviews.apache.org and the Review Board instance too if you like
Sent from my iPhone
On Jan 29, 2013, at 3:09 PM, "Michael Starch (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/OODT-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Michael Starch updated OODT-553:
> --------------------------------
>
> Attachment: OODT-553.patch.2013-01-29.txt
>
> This is a proposed patch.
>
> It uses System.getEnvironment() (instead of exec "env"). The test cases (additional) will only run on UNIX systems because they require USER and HOME environment variables to be set.
>
> Could another user review it? I am new.
>
> Enjoy!
>
>> Update org.apache.oodt.commons.exec.EnvUtilities to Use System.getEnvironment
>> -----------------------------------------------------------------------------
>>
>> Key: OODT-553
>> URL: https://issues.apache.org/jira/browse/OODT-553
>> Project: OODT
>> Issue Type: Improvement
>> Components: commons
>> Reporter: Michael Starch
>> Priority: Minor
>> Fix For: 0.6
>>
>> Attachments: OODT-553.patch.2013-01-29.txt
>>
>>
>> The environment variables utilities use a command line invocation of 'env' to get the environment variables due to the fact that java 1.4 did not have a System.getEnvironment call.
>> This is no longer the best solution (and is suspected of causing some errors).
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira