You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/14 05:43:55 UTC
Review Request 21426: Added a nav bar with Aurora logo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-381
https://issues.apache.org/jira/browse/AURORA-381
Repository: aurora
Description
-------
Added a nav bar with Aurora logo.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 817bd55a522f44831e81d0f2afe8e23bbfdbf52d
Diff: https://reviews.apache.org/r/21426/diff/
Testing
-------
Tested on local laptop.
File Attachments
----------------
Job page with nav bar
https://reviews.apache.org/media/uploaded/files/2014/05/14/a4338a79-72ba-4485-b0b0-86a8fdf23bca__Screen_Shot_2014-05-13_at_8.40.19_PM.png
home page with nav bar
https://reviews.apache.org/media/uploaded/files/2014/05/14/81c12d66-34e5-4c24-b432-85e64eb6cdc6__Screen_Shot_2014-05-13_at_8.40.24_PM.png
nav bar with a narrow page
https://reviews.apache.org/media/uploaded/files/2014/05/14/ef23cf5d-561a-4ae3-aad2-4321b1dd08e2__Screen_Shot_2014-05-13_at_8.40.48_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21426: Added a nav bar with Aurora logo.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/#review42992
-----------------------------------------------------------
Was hoping for something that looks more like the navbar at:
http://aurora.incubator.apache.org/
Although preferably with the logo made smaller to avoid taking up so much screen real estate.
- David McLaughlin
On May 14, 2014, 3:43 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21426/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 3:43 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-381
> https://issues.apache.org/jira/browse/AURORA-381
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a nav bar with Aurora logo.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 817bd55a522f44831e81d0f2afe8e23bbfdbf52d
>
> Diff: https://reviews.apache.org/r/21426/diff/
>
>
> Testing
> -------
>
> Tested on local laptop.
>
>
> File Attachments
> ----------------
>
> Job page with nav bar
> https://reviews.apache.org/media/uploaded/files/2014/05/14/a4338a79-72ba-4485-b0b0-86a8fdf23bca__Screen_Shot_2014-05-13_at_8.40.19_PM.png
> home page with nav bar
> https://reviews.apache.org/media/uploaded/files/2014/05/14/81c12d66-34e5-4c24-b432-85e64eb6cdc6__Screen_Shot_2014-05-13_at_8.40.24_PM.png
> nav bar with a narrow page
> https://reviews.apache.org/media/uploaded/files/2014/05/14/ef23cf5d-561a-4ae3-aad2-4321b1dd08e2__Screen_Shot_2014-05-13_at_8.40.48_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21426: Added a nav bar with Aurora logo.
Posted by Suman Karumuri <ma...@apache.org>.
> On May 14, 2014, 8:42 p.m., Chris Lambert wrote:
> > Are you using the correct logo (from AURORA-229)? It's hard to tell in the screenshot, but the green looks too dark. It should be #5BC2AE. Let me know if you need help.
The old logo was a darker color. Using the new logo with lighter green now. Please take another look at the screenshots. Would be happy to make changes.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/#review43018
-----------------------------------------------------------
On May 15, 2014, 1:34 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21426/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 1:34 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-381
> https://issues.apache.org/jira/browse/AURORA-381
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a nav bar with Aurora logo.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 983101277ffbd1c4017b29f4c86e61315f1bcc78
> src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora_logo.png PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 817bd55a522f44831e81d0f2afe8e23bbfdbf52d
>
> Diff: https://reviews.apache.org/r/21426/diff/
>
>
> Testing
> -------
>
> Tested on local laptop.
>
>
> File Attachments
> ----------------
>
> job page with header.
> https://reviews.apache.org/media/uploaded/files/2014/05/15/0df1216b-d58e-4720-932b-be1de2a053d0__Screen_Shot_2014-05-14_at_6.30.41_PM.png
> narrow page
> https://reviews.apache.org/media/uploaded/files/2014/05/15/9b32c1eb-6aae-4361-a82d-d90f89f54551__Screen_Shot_2014-05-14_at_6.32.47_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21426: Added a nav bar with Aurora logo.
Posted by Chris Lambert <cl...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/#review43018
-----------------------------------------------------------
Are you using the correct logo (from AURORA-229)? It's hard to tell in the screenshot, but the green looks too dark. It should be #5BC2AE. Let me know if you need help.
- Chris Lambert
On May 13, 2014, 8:43 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21426/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 8:43 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-381
> https://issues.apache.org/jira/browse/AURORA-381
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a nav bar with Aurora logo.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 817bd55a522f44831e81d0f2afe8e23bbfdbf52d
>
> Diff: https://reviews.apache.org/r/21426/diff/
>
>
> Testing
> -------
>
> Tested on local laptop.
>
>
> File Attachments
> ----------------
>
> Job page with nav bar
> https://reviews.apache.org/media/uploaded/files/2014/05/14/a4338a79-72ba-4485-b0b0-86a8fdf23bca__Screen_Shot_2014-05-13_at_8.40.19_PM.png
> home page with nav bar
> https://reviews.apache.org/media/uploaded/files/2014/05/14/81c12d66-34e5-4c24-b432-85e64eb6cdc6__Screen_Shot_2014-05-13_at_8.40.24_PM.png
> nav bar with a narrow page
> https://reviews.apache.org/media/uploaded/files/2014/05/14/ef23cf5d-561a-4ae3-aad2-4321b1dd08e2__Screen_Shot_2014-05-13_at_8.40.48_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21426: Added a nav bar with Aurora logo.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/#review43077
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On May 15, 2014, 1:34 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21426/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 1:34 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-381
> https://issues.apache.org/jira/browse/AURORA-381
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a nav bar with Aurora logo.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 983101277ffbd1c4017b29f4c86e61315f1bcc78
> src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora_logo.png PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 817bd55a522f44831e81d0f2afe8e23bbfdbf52d
>
> Diff: https://reviews.apache.org/r/21426/diff/
>
>
> Testing
> -------
>
> Tested on local laptop.
>
>
> File Attachments
> ----------------
>
> job page with header.
> https://reviews.apache.org/media/uploaded/files/2014/05/15/0df1216b-d58e-4720-932b-be1de2a053d0__Screen_Shot_2014-05-14_at_6.30.41_PM.png
> narrow page
> https://reviews.apache.org/media/uploaded/files/2014/05/15/9b32c1eb-6aae-4361-a82d-d90f89f54551__Screen_Shot_2014-05-14_at_6.32.47_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21426: Added a nav bar with Aurora logo.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/
-----------------------------------------------------------
(Updated May 15, 2014, 1:34 a.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Updated logo to be same as aurora home page.
Bugs: AURORA-381
https://issues.apache.org/jira/browse/AURORA-381
Repository: aurora
Description
-------
Added a nav bar with Aurora logo.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 983101277ffbd1c4017b29f4c86e61315f1bcc78
src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora_logo.png PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 817bd55a522f44831e81d0f2afe8e23bbfdbf52d
Diff: https://reviews.apache.org/r/21426/diff/
Testing
-------
Tested on local laptop.
File Attachments (updated)
----------------
job page with header.
https://reviews.apache.org/media/uploaded/files/2014/05/15/0df1216b-d58e-4720-932b-be1de2a053d0__Screen_Shot_2014-05-14_at_6.30.41_PM.png
narrow page
https://reviews.apache.org/media/uploaded/files/2014/05/15/9b32c1eb-6aae-4361-a82d-d90f89f54551__Screen_Shot_2014-05-14_at_6.32.47_PM.png
Thanks,
Suman Karumuri