You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/02/06 14:01:08 UTC

[GitHub] activemq-artemis pull request #1851: ARTEMIS-1664 fix npe bug while getting ...

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1851#discussion_r166307381
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java ---
    @@ -457,10 +457,10 @@ private void rehash() {
                 }
              }
     
    -         capacity = newCapacity;
              keys = newKeys;
              values = newValues;
              usedBuckets = size;
    +         capacity = newCapacity;
    --- End diff --
    
    Please check if is possible to use a lazySet too (maybe with an `AtomicFieldUpdater` or similar) to write release the keys/values in order to avoid a full barrier


---