[GitHub] [nifi] Evanthx commented on a change in pull request #3517: NIFI-6349 Fix to MergeRecords for fragments over multiple iterations

[GitBox <gi...@apache.org>]

Evanthx commented on a change in pull request #3517: NIFI-6349 Fix to MergeRecords for fragments over multiple iterations
URL: https://github.com/apache/nifi/pull/3517#discussion_r291692004
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/merge/RecordBinManager.java
 ##########
 @@ -195,6 +197,9 @@ private RecordBinThresholds createThresholds() {
         final String mergeStrategy = context.getProperty(MergeRecord.MERGE_STRATEGY).getValue();
         if (MergeRecord.MERGE_STRATEGY_DEFRAGMENT.getValue().equals(mergeStrategy)) {
             fragmentCountAttribute = MergeContent.FRAGMENT_COUNT_ATTRIBUTE;
+            if (!StringUtils.isEmpty(fragmentCountAttribute)) {
 
 Review comment:
   Oh man, I'm glad you caught that!! Thank you, you are exactly right. Checking in a fix now!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services