[jira] [Commented] (ZOOKEEPER-1790) Deal with special ObserverId in QuorumCnxManager.receiveConnection

["Thawan Kooburat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811837#comment-13811837 ] 

Thawan Kooburat commented on ZOOKEEPER-1790:
--------------------------------------------

In our internal deployment, we use negative sid to for observers  (actually all of them is -1) . This is probably not the intended usage but it worked so far.  It would be nice to add to release note of 3.5 if there is a change in the valid sid range. 

> Deal with special ObserverId in QuorumCnxManager.receiveConnection
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1790
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1790
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>             Fix For: 3.4.6, 3.5.0
>
>
> QuorumCnxManager.receiveConnection assumes that a negative sid means that this is a 3.5.0 server, which has a different communication protocol. This doesn't account for the fact that ObserverId = -1 is a special id that may be used by observers and is also negative. 
> This requires a fix to trunk and a separate fix to 3.4 branch, where this function is different (see ZOOKEEPER-1633)



--
This message was sent by Atlassian JIRA
(v6.1#6144)