You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/29 22:45:51 UTC
[GitHub] [beam] KevinGG opened a new pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
KevinGG opened a new pull request #14368:
URL: https://github.com/apache/beam/pull/14368
1. Added implementation of reading/writing cache directly on
pipeline protos for intermediate PCollections.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>SDK</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon">
</a>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img src="https://camo.githubusercontent.com/4565d7b7e907114e6c1d12323408bd903aa252fefed5eeab93701b05c9628a84/68747470733a2f2f63692d6265616d2e6170616368652e6f72672f6a6f622f6265616d5f507265436f6d6d69745f507974686f6e446f636b65725f43726f6e2f62616467652f69636f6e" alt="Build Status" data-canonical-src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img src="https://camo.githubusercontent.com/21afb097a5745440598bee5c59a027b140585eec871c3f3b883200610fabf722/68747470733a2f2f63692d6265616d2e6170616368652e6f72672f6a6f622f6265616d5f507265436f6d6d69745f507974686f6e446f63735f43726f6e2f62616467652f69636f6e" alt="Build Status" data-canonical-src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.44% +0.03%
==========================================
Files 469 472 +3
Lines 58736 58976 +240
==========================================
+ Hits 48988 49210 +222
- Misses 9748 9766 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ks/python/apache\_beam/runners/interactive/utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91dGlscy5weQ==) | | |
| [.../srcs/sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=) | | |
| [...ld/srcs/sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | | |
| [...amples/snippets/transforms/elementwise/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9fX2luaXRfXy5weQ==) | | |
| [...nners/direct/consumer\_tracking\_pipeline\_visitor.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvY29uc3VtZXJfdHJhY2tpbmdfcGlwZWxpbmVfdmlzaXRvci5weQ==) | | |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | | |
| [...rcs/sdks/python/apache\_beam/runners/job/manager.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9qb2IvbWFuYWdlci5weQ==) | | |
| [...apache\_beam/testing/benchmarks/nexmark/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvX19pbml0X18ucHk=) | | |
| [.../apache\_beam/testing/benchmarks/nexmark/monitor.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9uaXRvci5weQ==) | | |
| [...d/srcs/sdks/python/apache\_beam/ml/gcp/cloud\_dlp.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL2Nsb3VkX2RscC5weQ==) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...9214714](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-813706871
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/bae76b00d4515caad33976532fdd195bac5aa890?el=desc) (bae76b0) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.41% 83.44% +0.02%
==========================================
Files 938 472 -466
Lines 117474 58976 -58498
==========================================
- Hits 97991 49210 -48781
+ Misses 19483 9766 -9717
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...python/apache\_beam/runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvZGlyZWN0L2RpcmVjdF9ydW5uZXIucHk=) | | |
| [...py38/build/srcs/sdks/python/apache\_beam/version.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS92ZXJzaW9uLnB5) | | |
| [.../build/srcs/sdks/python/apache\_beam/io/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL19faW5pdF9fLnB5) | | |
| [.../srcs/sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL3Byb3RvX3V0aWxzLnB5) | | |
| [...am/examples/snippets/transforms/aggregation/max.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL3NuaXBwZXRzL3RyYW5zZm9ybXMvYWdncmVnYXRpb24vbWF4LnB5) | | |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | | |
| [...rcs/sdks/python/apache\_beam/transforms/timeutil.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3RyYW5zZm9ybXMvdGltZXV0aWwucHk=) | | |
| [...les/complete/juliaset/juliaset/juliaset\_test\_it.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9qdWxpYXNldC9qdWxpYXNldC9qdWxpYXNldF90ZXN0X2l0LnB5) | | |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9vcHRpb25zL3BpcGVsaW5lX29wdGlvbnMucHk=) | | |
| [...x/py38/build/srcs/sdks/python/apache\_beam/error.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9lcnJvci5weQ==) | | |
| ... and [1400 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...9214714](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/bae76b00d4515caad33976532fdd195bac5aa890?el=desc) (bae76b0) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9214714 differs from pull request most recent head 534d46f. Consider uploading reports for the commit 534d46f to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.41% 83.44% +0.02%
==========================================
Files 938 472 -466
Lines 117474 58976 -58498
==========================================
- Hits 97991 49210 -48781
+ Misses 19483 9766 -9717
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/snippets/transforms/aggregation/combineperkey.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL3NuaXBwZXRzL3RyYW5zZm9ybXMvYWdncmVnYXRpb24vY29tYmluZXBlcmtleS5weQ==) | | |
| [...rcs/sdks/python/apache\_beam/io/aws/s3filesystem.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9hd3MvczNmaWxlc3lzdGVtLnB5) | | |
| [...s/sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9leHRlcm5hbC9zbm93Zmxha2UucHk=) | | |
| [...sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pbnRlcm5hbC9tZXRyaWNzL21ldHJpYy5weQ==) | | |
| [...ild/srcs/sdks/python/apache\_beam/io/gcp/spanner.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9zcGFubmVyLnB5) | | |
| [.../apache\_beam/examples/cookbook/group\_with\_coder.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb29rYm9vay9ncm91cF93aXRoX2NvZGVyLnB5) | | |
| [...am/examples/complete/juliaset/juliaset/juliaset.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2p1bGlhc2V0L2p1bGlhc2V0L2p1bGlhc2V0LnB5) | | |
| [...ache\_beam/coders/proto2\_coder\_test\_messages\_pb2.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9jb2RlcnMvcHJvdG8yX2NvZGVyX3Rlc3RfbWVzc2FnZXNfcGIyLnB5) | | |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvZGF0YWZsb3cvcHRyYW5zZm9ybV9vdmVycmlkZXMucHk=) | | |
| [...apache\_beam/examples/complete/game/leader\_board.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9nYW1lL2xlYWRlcl9ib2FyZC5weQ==) | | |
| ... and [1400 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...534d46f](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (ff4ffee) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.42% +0.02%
==========================================
Files 469 472 +3
Lines 58736 58943 +207
==========================================
+ Hits 48988 49175 +187
- Misses 9748 9768 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...python/apache\_beam/examples/streaming\_wordcount.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudC5weQ==) | | |
| [.../build/srcs/sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | | |
| [.../python/apache\_beam/io/gcp/tests/pubsub\_matcher.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL3B1YnN1Yl9tYXRjaGVyLnB5) | | |
| [...rcs/sdks/python/apache\_beam/io/aws/s3filesystem.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL3MzZmlsZXN5c3RlbS5weQ==) | | |
| [...examples/snippets/transforms/aggregation/latest.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9sYXRlc3QucHk=) | | |
| [...pache\_beam/runners/portability/artifact\_service.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9hcnRpZmFjdF9zZXJ2aWNlLnB5) | | |
| [...am/testing/benchmarks/chicago\_taxi/trainer/task.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL3Rhc2sucHk=) | | |
| [...ython/apache\_beam/io/aws/clients/s3/fake\_client.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvZmFrZV9jbGllbnQucHk=) | | |
| [...ld/srcs/sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGltZXN0YW1wLnB5) | | |
| [...on/apache\_beam/runners/portability/flink\_runner.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbGlua19ydW5uZXIucHk=) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...ff4ffee](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rohdesamuel commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605160116
##########
File path: sdks/python/apache_beam/runners/interactive/caching/read_cache.py
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to read cache of computed PCollections.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.transforms.ptransform import PTransform
+
+
+class ReadCache:
+ """Class that facilitates reading cache of computed PCollections.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def read_cache(self) -> Tuple[str, str]:
+ """Reads cache of the cacheable PCollection and wires the cache into the
+ pipeline proto. Returns the pipeline-scoped ids of the cacheable PCollection
+ and the cache reading output PCollection that replaces it.
+ """
+ template, read_output = self._build_runner_api_template()
+ output_id = self._context.pcollections.get_id(read_output)
+ source_id = self._context.pcollections.get_id(self._cacheable.pcoll)
+ # Copy cache reading subgraph from the template to the pipeline proto.
+ for pcoll_id in template.components.pcollections:
+ if pcoll_id in self._pipeline.components.pcollections:
+ continue
+ self._pipeline.components.pcollections[pcoll_id].CopyFrom(
+ template.components.pcollections[pcoll_id])
+ for coder_id in template.components.coders:
+ if coder_id in self._pipeline.components.coders:
+ continue
+ self._pipeline.components.coders[coder_id].CopyFrom(
+ template.components.coders[coder_id])
+ for windowing_strategy_id in template.components.windowing_strategies:
+ if windowing_strategy_id in \
+ self._pipeline.components.windowing_strategies:
Review comment:
Prefer wrapping line in parentheses instead of using backslash.
##########
File path: sdks/python/apache_beam/runners/interactive/caching/read_cache.py
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to read cache of computed PCollections.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.transforms.ptransform import PTransform
+
+
+class ReadCache:
+ """Class that facilitates reading cache of computed PCollections.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def read_cache(self) -> Tuple[str, str]:
Review comment:
Can you please add more comments in here to inform the reader what these proto transformations are doing and why?
##########
File path: sdks/python/apache_beam/runners/interactive/caching/write_cache.py
##########
@@ -0,0 +1,170 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to write cache for PCollections being computed.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.testing import test_stream
+from apache_beam.transforms.ptransform import PTransform
+from apache_beam.transforms.window import WindowedValue
+
+
+class WriteCache:
+ """Class that facilitates writing cache for PCollections being computed.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def write_cache(self) -> None:
Review comment:
More comments in this method too, please.
##########
File path: sdks/python/apache_beam/runners/interactive/caching/write_cache.py
##########
@@ -0,0 +1,170 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to write cache for PCollections being computed.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.testing import test_stream
+from apache_beam.transforms.ptransform import PTransform
+from apache_beam.transforms.window import WindowedValue
+
+
+class WriteCache:
+ """Class that facilitates writing cache for PCollections being computed.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def write_cache(self) -> None:
+ """Writes cache for the cacheable PCollection that is being computed.
+ """
+ template, write_input_placeholder = self._build_runner_api_template()
+ input_placeholder_id = self._context.pcollections.get_id(
+ write_input_placeholder.placeholder_pcoll)
+ input_id = self._context.pcollections.get_id(self._cacheable.pcoll)
+
+ # Copy cache writing subgraph from the template to the pipeline proto.
+ for pcoll_id in template.components.pcollections:
Review comment:
I'm not sure that this code is correct. The component ids (PCollection ids, coder ids, etc.) are specific to a given pipeline. In other words, given a component id in one pipeline there is no guarantee that the component is the same given the same component id in another pipeline.
Instead of doing this equality of ids between pipelines, it might be better to recursively iterate through the temporary pipeline and copy components over to _pipeline. You'll have to be careful though as the pipeline proto has some hidden ordering guarantees, like the transforms need to be in a topological ordering.
##########
File path: sdks/python/apache_beam/runners/interactive/augmented_pipeline.py
##########
@@ -0,0 +1,137 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to augment interactive flavor into the given pipeline.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import copy
+from typing import Dict
+from typing import Optional
+from typing import Set
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import interactive_environment as ie
+from apache_beam.runners.interactive import background_caching_job
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.interactive.caching.read_cache import ReadCache
+from apache_beam.runners.interactive.caching.write_cache import WriteCache
+
+
+class AugmentedPipeline:
+ """A pipeline with augmented interactive flavor that caches intermediate
+ PCollections defined by the user, reads computed PCollections as source and
+ prunes unnecessary pipeline parts for fast computation.
+ """
+ def __init__(
+ self,
+ user_pipeline: beam.Pipeline,
+ pcolls: Optional[Set[beam.pvalue.PCollection]] = None):
+ """
+ Initializes a pipelilne for augmenting interactive flavor.
+
+ Args:
+ user_pipeline: a beam.Pipeline instance defined by the user.
+ pcolls: cacheable pcolls to be computed/retrieved. If the set is
+ empty, all intermediate pcolls assigned to variables are applicable.
+ """
+ assert not pcolls or all([pcoll.pipeline is user_pipeline for pcoll in
+ pcolls]), 'All %s need to belong to %s' % (pcolls, user_pipeline)
+ self._user_pipeline = user_pipeline
+ self._pcolls = pcolls
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline, create_if_absent=True)
+ if background_caching_job.has_source_to_cache(self._user_pipeline):
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline)
+ self._pipeline, self._context = self._user_pipeline.to_runner_api(
+ return_context=True)
+ self._context.component_id_map = copy.copy(
+ self._user_pipeline.component_id_map)
+ self._cacheables = self.cacheables()
+ self._augmented = False
+
+ @property
+ def augmented_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ assert self._augmented, 'Call augment() before retrieving the value.'
+ return self._pipeline
+
+ # TODO(BEAM-10708): Support generating a background recording job that
+ # contains unbound source recording transforms only.
+ @property
+ def background_recording_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ raise NotImplementedError
+
+ def cacheables(self) -> Dict[beam.pvalue.PCollection, Cacheable]:
+ """Finds all the cacheable intermediate PCollections in the pipeline with
+ their metadata.
+ """
+ c = {}
+ for watching in ie.current_env().watching():
+ for key, val in watching:
+ if (isinstance(val, beam.pvalue.PCollection) and
+ val.pipeline is self._user_pipeline and
+ (not self._pcolls or val in self._pcolls)):
+ pcoll_id = self._context.pcollections.get_id(val)
+ c[val] = Cacheable(
+ pcoll_id=pcoll_id,
+ var=key,
+ pcoll=val,
+ version=str(id(val)),
+ producer_version=str(id(val.producer)))
+ return c
+
+ def augment(self) -> 'AugmentedPipeline':
+ """Augments the pipeline with cache. Idempotent and returns self.
+
+ For a cacheable PCollection, if cache exists, read cache; else, write cache.
+ """
+ if self._augmented:
+ return self
+ self._augmented = True
Review comment:
Instead of having state that tracks whether the pipeline is augmented, it's a simpler API to have this always augment the user pipeline and let the client handle caching the result.
##########
File path: sdks/python/apache_beam/runners/interactive/augmented_pipeline.py
##########
@@ -0,0 +1,137 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to augment interactive flavor into the given pipeline.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import copy
+from typing import Dict
+from typing import Optional
+from typing import Set
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import interactive_environment as ie
+from apache_beam.runners.interactive import background_caching_job
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.interactive.caching.read_cache import ReadCache
+from apache_beam.runners.interactive.caching.write_cache import WriteCache
+
+
+class AugmentedPipeline:
+ """A pipeline with augmented interactive flavor that caches intermediate
+ PCollections defined by the user, reads computed PCollections as source and
+ prunes unnecessary pipeline parts for fast computation.
+ """
+ def __init__(
+ self,
+ user_pipeline: beam.Pipeline,
+ pcolls: Optional[Set[beam.pvalue.PCollection]] = None):
+ """
+ Initializes a pipelilne for augmenting interactive flavor.
+
+ Args:
+ user_pipeline: a beam.Pipeline instance defined by the user.
+ pcolls: cacheable pcolls to be computed/retrieved. If the set is
+ empty, all intermediate pcolls assigned to variables are applicable.
+ """
+ assert not pcolls or all([pcoll.pipeline is user_pipeline for pcoll in
+ pcolls]), 'All %s need to belong to %s' % (pcolls, user_pipeline)
+ self._user_pipeline = user_pipeline
+ self._pcolls = pcolls
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline, create_if_absent=True)
+ if background_caching_job.has_source_to_cache(self._user_pipeline):
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline)
+ self._pipeline, self._context = self._user_pipeline.to_runner_api(
+ return_context=True)
+ self._context.component_id_map = copy.copy(
+ self._user_pipeline.component_id_map)
+ self._cacheables = self.cacheables()
+ self._augmented = False
+
+ @property
+ def augmented_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ assert self._augmented, 'Call augment() before retrieving the value.'
+ return self._pipeline
+
+ # TODO(BEAM-10708): Support generating a background recording job that
+ # contains unbound source recording transforms only.
+ @property
+ def background_recording_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ raise NotImplementedError
+
+ def cacheables(self) -> Dict[beam.pvalue.PCollection, Cacheable]:
+ """Finds all the cacheable intermediate PCollections in the pipeline with
+ their metadata.
+ """
+ c = {}
+ for watching in ie.current_env().watching():
+ for key, val in watching:
+ if (isinstance(val, beam.pvalue.PCollection) and
+ val.pipeline is self._user_pipeline and
+ (not self._pcolls or val in self._pcolls)):
+ pcoll_id = self._context.pcollections.get_id(val)
+ c[val] = Cacheable(
+ pcoll_id=pcoll_id,
+ var=key,
+ pcoll=val,
+ version=str(id(val)),
+ producer_version=str(id(val.producer)))
+ return c
+
+ def augment(self) -> 'AugmentedPipeline':
+ """Augments the pipeline with cache. Idempotent and returns self.
+
+ For a cacheable PCollection, if cache exists, read cache; else, write cache.
+ """
+ if self._augmented:
+ return self
+ self._augmented = True
+
+ # Find pcolls eligible for reading or writing cache.
+ readcache_pcolls = set()
+ for pcoll, cacheable in self._cacheables.items():
+ key = repr(cacheable.to_key())
+ if (self._cache_manager.exists('full', key) and
+ pcoll in ie.current_env().computed_pcollections):
Review comment:
Is there ever a case where a PCollection is computed but doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/bae76b00d4515caad33976532fdd195bac5aa890?el=desc) (bae76b0) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9214714 differs from pull request most recent head a412da9. Consider uploading reports for the commit a412da9 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.41% 83.44% +0.02%
==========================================
Files 938 472 -466
Lines 117474 58976 -58498
==========================================
- Hits 97991 49210 -48781
+ Misses 19483 9766 -9717
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/portability/api/schema\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3BvcnRhYmlsaXR5L2FwaS9zY2hlbWFfcGIyX2dycGMucHk=) | | |
| [...thon/apache\_beam/runners/worker/operation\_specs.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9vcGVyYXRpb25fc3BlY3MucHk=) | | |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L2pvYl9zZXJ2ZXIucHk=) | | |
| [...y38/build/srcs/sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9waXBlbGluZS5weQ==) | | |
| [.../py38/build/srcs/sdks/python/apache\_beam/pvalue.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wdmFsdWUucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/io/flink/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9mbGluay9fX2luaXRfXy5weQ==) | | |
| [.../apache\_beam/examples/cookbook/group\_with\_coder.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2dyb3VwX3dpdGhfY29kZXIucHk=) | | |
| [...s/python/apache\_beam/testing/pipeline\_verifiers.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX1BocmFzZS9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL3BpcGVsaW5lX3ZlcmlmaWVycy5weQ==) | | |
| [...amples/snippets/transforms/elementwise/tostring.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL3NuaXBwZXRzL3RyYW5zZm9ybXMvZWxlbWVudHdpc2UvdG9zdHJpbmcucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/dataframe/schemas.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2RhdGFmcmFtZS9zY2hlbWFzLnB5) | | |
| ... and [1400 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...a412da9](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.44% +0.03%
==========================================
Files 469 472 +3
Lines 58736 58976 +240
==========================================
+ Hits 48988 49210 +222
- Misses 9748 9766 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...build/srcs/sdks/python/apache\_beam/io/parquetio.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vcGFycXVldGlvLnB5) | | |
| [...ransforms/transforms\_keyword\_only\_args\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy90cmFuc2Zvcm1zX2tleXdvcmRfb25seV9hcmdzX3Rlc3RfcHkzLnB5) | | |
| [...sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | | |
| [...ks/python/apache\_beam/internal/metrics/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9fX2luaXRfXy5weQ==) | | |
| [...hon/apache\_beam/runners/direct/direct\_userstate.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X3VzZXJzdGF0ZS5weQ==) | | |
| [...he\_beam/io/flink/flink\_streaming\_impulse\_source.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmxpbmsvZmxpbmtfc3RyZWFtaW5nX2ltcHVsc2Vfc291cmNlLnB5) | | |
| [...ache\_beam/testing/benchmarks/chicago\_taxi/setup.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9zZXR1cC5weQ==) | | |
| [...he\_beam/portability/api/external\_transforms\_pb2.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyLnB5) | | |
| [...srcs/sdks/python/apache\_beam/transforms/trigger.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy90cmlnZ2VyLnB5) | | |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...9214714](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-814483459
Rebased to take a flaky test fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (6d26c75) into [master](https://codecov.io/gh/apache/beam/commit/79578bce56eb3abc4d21a65e73cccb6ffa9173c5?el=desc) (79578bc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.49% 83.52% +0.02%
==========================================
Files 463 466 +3
Lines 58927 59135 +208
==========================================
+ Hits 49201 49392 +191
- Misses 9726 9743 +17
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3Rlc3RpbmcvdGVzdF9jYWNoZV9tYW5hZ2VyLnB5) | `92.95% <0.00%> (-1.25%)` | :arrow_down: |
| [...m/runners/portability/spark\_uber\_jar\_job\_server.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L3NwYXJrX3ViZXJfamFyX2pvYl9zZXJ2ZXIucHk=) | `85.60% <0.00%> (ø)` | |
| [...he\_beam/runners/interactive/caching/write\_cache.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2NhY2hpbmcvd3JpdGVfY2FjaGUucHk=) | `94.11% <0.00%> (ø)` | |
| [...che\_beam/runners/interactive/caching/read\_cache.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2NhY2hpbmcvcmVhZF9jYWNoZS5weQ==) | `93.93% <0.00%> (ø)` | |
| [...che\_beam/runners/interactive/augmented\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2F1Z21lbnRlZF9waXBlbGluZS5weQ==) | `70.58% <0.00%> (ø)` | |
| [...d/srcs/sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvZnJhbWVzLnB5) | `93.25% <0.00%> (+0.02%)` | :arrow_up: |
| [...ild/srcs/sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2NvbW1vbi5weQ==) | `89.41% <0.00%> (+0.14%)` | :arrow_up: |
| [.../py38/build/srcs/sdks/python/apache\_beam/pvalue.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wdmFsdWUucHk=) | `93.12% <0.00%> (+0.38%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9kYXRhX3BsYW5lLnB5) | `91.31% <0.00%> (+1.79%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...6d26c75](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-815346012
The failure of action is from portable runner tests. Not related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (719318b) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 719318b differs from pull request most recent head dd87e14. Consider uploading reports for the commit dd87e14 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49294 +87
- Misses 9723 9742 +19
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...dd87e14](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (dd87e14) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49293 +86
- Misses 9723 9743 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...dd87e14](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605230817
##########
File path: sdks/python/apache_beam/runners/interactive/caching/write_cache.py
##########
@@ -0,0 +1,170 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to write cache for PCollections being computed.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.testing import test_stream
+from apache_beam.transforms.ptransform import PTransform
+from apache_beam.transforms.window import WindowedValue
+
+
+class WriteCache:
+ """Class that facilitates writing cache for PCollections being computed.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def write_cache(self) -> None:
+ """Writes cache for the cacheable PCollection that is being computed.
+ """
+ template, write_input_placeholder = self._build_runner_api_template()
+ input_placeholder_id = self._context.pcollections.get_id(
+ write_input_placeholder.placeholder_pcoll)
+ input_id = self._context.pcollections.get_id(self._cacheable.pcoll)
+
+ # Copy cache writing subgraph from the template to the pipeline proto.
+ for pcoll_id in template.components.pcollections:
Review comment:
This I can explain:
TL;DR: the `component_id_map` of a pipeline instance (also backs the pipeline context) is where each Python object is assigned a unique pipeline-scoped id. By making a shallow copy of it before augmenting and passing it into the temporary pipelines as a shared context for new components, we can guarantee all ids are unique even if they come from different pipeline instances.
- The underlying mechanism of the `component_id_map` are:
- a dictionary holds counters of different object types as `Dict[type, int]`;
- a dictionary holds object to id map as `Dict[Any, str]`.
- All the temporary pipelines will generate components as if a sub graph in the original pipeline: ids of all the components are unique even to the current state of the augmented pipeline.
- The code moves the top level transforms of that subgraph into the runner api proto of the pipeline being augmented.
- The `pcoll_id in self._pipeline.components.pcollections ...` checks to skip ids from the shared context (`component_id_map`) that definitely do not exist in the temp pipeline and do not need copy at all.
- The `pcoll_id in write_input_placeholder.ignorable_components.pcollections ...` checks to skip unnecessary root transforms (because you don't need two root transforms) and placeholder subgraphs (as if they are pruned when we add cache transforms) since we only care about top level transforms that we need. It's kind of like moving everything there then pruning the unnecessary parts.
- The copy should preserve the topological ordering since it reads the proto of the temp pipeline in its original order and does the same thing to `set_proto_map` in `pipeline_instrument`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (ff4ffee) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.42% +0.02%
==========================================
Files 469 472 +3
Lines 58736 58943 +207
==========================================
+ Hits 48988 49175 +187
- Misses 9748 9768 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/io/gcp/bigquery\_io\_metadata.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2lvX21ldGFkYXRhLnB5) | | |
| [...d/srcs/sdks/python/apache\_beam/transforms/stats.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zdGF0cy5weQ==) | | |
| [.../sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | | |
| [...beam/testing/benchmarks/nexmark/models/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL19faW5pdF9fLnB5) | | |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query3.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTMucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL29wY29kZXMucHk=) | | |
| [...ers/interactive/testing/integration/screen\_diff.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3NjcmVlbl9kaWZmLnB5) | | |
| [...he\_beam/io/flink/flink\_streaming\_impulse\_source.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmxpbmsvZmxpbmtfc3RyZWFtaW5nX2ltcHVsc2Vfc291cmNlLnB5) | | |
| [...ive/messaging/interactive\_environment\_inspector.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9tZXNzYWdpbmcvaW50ZXJhY3RpdmVfZW52aXJvbm1lbnRfaW5zcGVjdG9yLnB5) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...ff4ffee](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (6d26c75) into [master](https://codecov.io/gh/apache/beam/commit/79578bce56eb3abc4d21a65e73cccb6ffa9173c5?el=desc) (79578bc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.49% 83.52% +0.02%
==========================================
Files 463 466 +3
Lines 58927 59135 +208
==========================================
+ Hits 49201 49392 +191
- Misses 9726 9743 +17
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3Rlc3RpbmcvdGVzdF9jYWNoZV9tYW5hZ2VyLnB5) | `92.95% <0.00%> (-1.25%)` | :arrow_down: |
| [...m/runners/portability/spark\_uber\_jar\_job\_server.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L3NwYXJrX3ViZXJfamFyX2pvYl9zZXJ2ZXIucHk=) | `85.60% <0.00%> (ø)` | |
| [...che\_beam/runners/interactive/caching/read\_cache.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2NhY2hpbmcvcmVhZF9jYWNoZS5weQ==) | `93.93% <0.00%> (ø)` | |
| [...he\_beam/runners/interactive/caching/write\_cache.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2NhY2hpbmcvd3JpdGVfY2FjaGUucHk=) | `94.11% <0.00%> (ø)` | |
| [...che\_beam/runners/interactive/augmented\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2F1Z21lbnRlZF9waXBlbGluZS5weQ==) | `70.58% <0.00%> (ø)` | |
| [...d/srcs/sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvZnJhbWVzLnB5) | `93.25% <0.00%> (+0.02%)` | :arrow_up: |
| [...ild/srcs/sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2NvbW1vbi5weQ==) | `89.41% <0.00%> (+0.14%)` | :arrow_up: |
| [.../py38/build/srcs/sdks/python/apache\_beam/pvalue.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wdmFsdWUucHk=) | `93.12% <0.00%> (+0.38%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9kYXRhX3BsYW5lLnB5) | `91.31% <0.00%> (+1.79%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...6d26c75](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-815107722
Run Portable_Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (dd87e14) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49293 +86
- Misses 9723 9743 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...dd87e14](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809767417
R: @rohdesamuel
PTAL, thx!
A test notebook that reads cache from a computed PCollection, applies a transform, and then writes the cache for the PCollection being computed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605237537
##########
File path: sdks/python/apache_beam/runners/interactive/augmented_pipeline.py
##########
@@ -0,0 +1,137 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to augment interactive flavor into the given pipeline.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import copy
+from typing import Dict
+from typing import Optional
+from typing import Set
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import interactive_environment as ie
+from apache_beam.runners.interactive import background_caching_job
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.interactive.caching.read_cache import ReadCache
+from apache_beam.runners.interactive.caching.write_cache import WriteCache
+
+
+class AugmentedPipeline:
+ """A pipeline with augmented interactive flavor that caches intermediate
+ PCollections defined by the user, reads computed PCollections as source and
+ prunes unnecessary pipeline parts for fast computation.
+ """
+ def __init__(
+ self,
+ user_pipeline: beam.Pipeline,
+ pcolls: Optional[Set[beam.pvalue.PCollection]] = None):
+ """
+ Initializes a pipelilne for augmenting interactive flavor.
+
+ Args:
+ user_pipeline: a beam.Pipeline instance defined by the user.
+ pcolls: cacheable pcolls to be computed/retrieved. If the set is
+ empty, all intermediate pcolls assigned to variables are applicable.
+ """
+ assert not pcolls or all([pcoll.pipeline is user_pipeline for pcoll in
+ pcolls]), 'All %s need to belong to %s' % (pcolls, user_pipeline)
+ self._user_pipeline = user_pipeline
+ self._pcolls = pcolls
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline, create_if_absent=True)
+ if background_caching_job.has_source_to_cache(self._user_pipeline):
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline)
+ self._pipeline, self._context = self._user_pipeline.to_runner_api(
+ return_context=True)
+ self._context.component_id_map = copy.copy(
+ self._user_pipeline.component_id_map)
+ self._cacheables = self.cacheables()
+ self._augmented = False
+
+ @property
+ def augmented_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ assert self._augmented, 'Call augment() before retrieving the value.'
+ return self._pipeline
+
+ # TODO(BEAM-10708): Support generating a background recording job that
+ # contains unbound source recording transforms only.
+ @property
+ def background_recording_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ raise NotImplementedError
+
+ def cacheables(self) -> Dict[beam.pvalue.PCollection, Cacheable]:
+ """Finds all the cacheable intermediate PCollections in the pipeline with
+ their metadata.
+ """
+ c = {}
+ for watching in ie.current_env().watching():
+ for key, val in watching:
+ if (isinstance(val, beam.pvalue.PCollection) and
+ val.pipeline is self._user_pipeline and
+ (not self._pcolls or val in self._pcolls)):
+ pcoll_id = self._context.pcollections.get_id(val)
+ c[val] = Cacheable(
+ pcoll_id=pcoll_id,
+ var=key,
+ pcoll=val,
+ version=str(id(val)),
+ producer_version=str(id(val.producer)))
+ return c
+
+ def augment(self) -> 'AugmentedPipeline':
+ """Augments the pipeline with cache. Idempotent and returns self.
+
+ For a cacheable PCollection, if cache exists, read cache; else, write cache.
+ """
+ if self._augmented:
+ return self
+ self._augmented = True
+
+ # Find pcolls eligible for reading or writing cache.
+ readcache_pcolls = set()
+ for pcoll, cacheable in self._cacheables.items():
+ key = repr(cacheable.to_key())
+ if (self._cache_manager.exists('full', key) and
+ pcoll in ie.current_env().computed_pcollections):
Review comment:
If the temp directory is cleaned up by other processes, or if we have a bug, then yes. I guess it doesn't hurt to check it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (dd87e14) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49293 +86
- Misses 9723 9743 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...dd87e14](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605239611
##########
File path: sdks/python/apache_beam/runners/interactive/caching/read_cache.py
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to read cache of computed PCollections.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.transforms.ptransform import PTransform
+
+
+class ReadCache:
+ """Class that facilitates reading cache of computed PCollections.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def read_cache(self) -> Tuple[str, str]:
Review comment:
I'll add more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (ff4ffee) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.42% +0.02%
==========================================
Files 469 472 +3
Lines 58736 58943 +207
==========================================
+ Hits 48988 49175 +187
- Misses 9748 9768 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...python/apache\_beam/io/gcp/experimental/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2V4cGVyaW1lbnRhbC9fX2luaXRfXy5weQ==) | | |
| [...ython/apache\_beam/io/gcp/datastore/v1new/helper.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9oZWxwZXIucHk=) | | |
| [...am/examples/complete/juliaset/juliaset/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvX19pbml0X18ucHk=) | | |
| [...s/python/apache\_beam/testing/datatype\_inference.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9kYXRhdHlwZV9pbmZlcmVuY2UucHk=) | | |
| [...flow/internal/clients/dataflow/message\_matchers.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L21lc3NhZ2VfbWF0Y2hlcnMucHk=) | | |
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | | |
| [...y38/build/srcs/sdks/python/apache\_beam/io/kafka.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2Fma2EucHk=) | | |
| [...cs/sdks/python/apache\_beam/dataframe/transforms.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3RyYW5zZm9ybXMucHk=) | | |
| [...nippets/transforms/aggregation/groupintobatches.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9ncm91cGludG9iYXRjaGVzLnB5) | | |
| [...s/sdks/python/apache\_beam/internal/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL19faW5pdF9fLnB5) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...ff4ffee](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (dd87e14) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49293 +86
- Misses 9723 9743 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...dd87e14](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/79578bce56eb3abc4d21a65e73cccb6ffa9173c5?el=desc) (79578bc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9214714 differs from pull request most recent head 6d26c75. Consider uploading reports for the commit 6d26c75 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.49% 83.44% -0.06%
==========================================
Files 463 472 +9
Lines 58927 58976 +49
==========================================
+ Hits 49201 49210 +9
- Misses 9726 9766 +40
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/typehints/trivial\_inference.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvdHJpdmlhbF9pbmZlcmVuY2UucHk=) | `89.60% <0.00%> (-7.13%)` | :arrow_down: |
| [...apache\_beam/typehints/native\_type\_compatibility.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvbmF0aXZlX3R5cGVfY29tcGF0aWJpbGl0eS5weQ==) | `83.43% <0.00%> (-3.11%)` | :arrow_down: |
| [.../srcs/sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvb3Bjb2Rlcy5weQ==) | `87.91% <0.00%> (-2.88%)` | :arrow_down: |
| [...s/python/apache\_beam/utils/thread\_pool\_executor.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS91dGlscy90aHJlYWRfcG9vbF9leGVjdXRvci5weQ==) | `88.37% <0.00%> (-1.88%)` | :arrow_down: |
| [...rcs/sdks/python/apache\_beam/transforms/external.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2V4dGVybmFsLnB5) | `72.48% <0.00%> (-0.91%)` | :arrow_down: |
| [.../srcs/sdks/python/apache\_beam/typehints/schemas.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvc2NoZW1hcy5weQ==) | `93.71% <0.00%> (-0.49%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/interactive/utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3V0aWxzLnB5) | `92.38% <0.00%> (-0.42%)` | :arrow_down: |
| [.../srcs/sdks/python/apache\_beam/transforms/window.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL3dpbmRvdy5weQ==) | `86.87% <0.00%> (-0.39%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...sdks/python/apache\_beam/utils/subprocess\_server.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS91dGlscy9zdWJwcm9jZXNzX3NlcnZlci5weQ==) | `53.14% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...6d26c75](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605238020
##########
File path: sdks/python/apache_beam/runners/interactive/augmented_pipeline.py
##########
@@ -0,0 +1,137 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to augment interactive flavor into the given pipeline.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import copy
+from typing import Dict
+from typing import Optional
+from typing import Set
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import interactive_environment as ie
+from apache_beam.runners.interactive import background_caching_job
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.interactive.caching.read_cache import ReadCache
+from apache_beam.runners.interactive.caching.write_cache import WriteCache
+
+
+class AugmentedPipeline:
+ """A pipeline with augmented interactive flavor that caches intermediate
+ PCollections defined by the user, reads computed PCollections as source and
+ prunes unnecessary pipeline parts for fast computation.
+ """
+ def __init__(
+ self,
+ user_pipeline: beam.Pipeline,
+ pcolls: Optional[Set[beam.pvalue.PCollection]] = None):
+ """
+ Initializes a pipelilne for augmenting interactive flavor.
+
+ Args:
+ user_pipeline: a beam.Pipeline instance defined by the user.
+ pcolls: cacheable pcolls to be computed/retrieved. If the set is
+ empty, all intermediate pcolls assigned to variables are applicable.
+ """
+ assert not pcolls or all([pcoll.pipeline is user_pipeline for pcoll in
+ pcolls]), 'All %s need to belong to %s' % (pcolls, user_pipeline)
+ self._user_pipeline = user_pipeline
+ self._pcolls = pcolls
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline, create_if_absent=True)
+ if background_caching_job.has_source_to_cache(self._user_pipeline):
+ self._cache_manager = ie.current_env().get_cache_manager(
+ self._user_pipeline)
+ self._pipeline, self._context = self._user_pipeline.to_runner_api(
+ return_context=True)
+ self._context.component_id_map = copy.copy(
+ self._user_pipeline.component_id_map)
+ self._cacheables = self.cacheables()
+ self._augmented = False
+
+ @property
+ def augmented_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ assert self._augmented, 'Call augment() before retrieving the value.'
+ return self._pipeline
+
+ # TODO(BEAM-10708): Support generating a background recording job that
+ # contains unbound source recording transforms only.
+ @property
+ def background_recording_pipeline(self) -> beam_runner_api_pb2.Pipeline:
+ raise NotImplementedError
+
+ def cacheables(self) -> Dict[beam.pvalue.PCollection, Cacheable]:
+ """Finds all the cacheable intermediate PCollections in the pipeline with
+ their metadata.
+ """
+ c = {}
+ for watching in ie.current_env().watching():
+ for key, val in watching:
+ if (isinstance(val, beam.pvalue.PCollection) and
+ val.pipeline is self._user_pipeline and
+ (not self._pcolls or val in self._pcolls)):
+ pcoll_id = self._context.pcollections.get_id(val)
+ c[val] = Cacheable(
+ pcoll_id=pcoll_id,
+ var=key,
+ pcoll=val,
+ version=str(id(val)),
+ producer_version=str(id(val.producer)))
+ return c
+
+ def augment(self) -> 'AugmentedPipeline':
+ """Augments the pipeline with cache. Idempotent and returns self.
+
+ For a cacheable PCollection, if cache exists, read cache; else, write cache.
+ """
+ if self._augmented:
+ return self
+ self._augmented = True
Review comment:
That makes sense, I'll make a change to always calculate a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (9214714) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.44% +0.03%
==========================================
Files 469 472 +3
Lines 58736 58976 +240
==========================================
+ Hits 48988 49210 +222
- Misses 9748 9766 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | | |
| [.../srcs/sdks/python/apache\_beam/internal/gcp/auth.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2F1dGgucHk=) | | |
| [...srcs/sdks/python/apache\_beam/io/gcp/dicomclient.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RpY29tY2xpZW50LnB5) | | |
| [...sdks/python/apache\_beam/examples/flink/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvZmxpbmsvX19pbml0X18ucHk=) | | |
| [...am/testing/benchmarks/nexmark/models/field\_name.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL2ZpZWxkX25hbWUucHk=) | | |
| [...hon/apache\_beam/runners/direct/direct\_userstate.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X3VzZXJzdGF0ZS5weQ==) | | |
| [...ld/srcs/sdks/python/apache\_beam/utils/processes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvY2Vzc2VzLnB5) | | |
| [.../examples/snippets/transforms/aggregation/count.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb3VudC5weQ==) | | |
| [...thon/apache\_beam/io/azure/blobstoragefilesystem.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2VmaWxlc3lzdGVtLnB5) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...9214714](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (ff4ffee) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.42% +0.02%
==========================================
Files 469 472 +3
Lines 58736 58943 +207
==========================================
+ Hits 48988 49175 +187
- Misses 9748 9768 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/io/gcp/bigquery\_io\_metadata.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2lvX21ldGFkYXRhLnB5) | | |
| [...d/srcs/sdks/python/apache\_beam/transforms/stats.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zdGF0cy5weQ==) | | |
| [.../sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | | |
| [...beam/testing/benchmarks/nexmark/models/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL19faW5pdF9fLnB5) | | |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query3.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTMucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL29wY29kZXMucHk=) | | |
| [...ers/interactive/testing/integration/screen\_diff.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3NjcmVlbl9kaWZmLnB5) | | |
| [...he\_beam/io/flink/flink\_streaming\_impulse\_source.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmxpbmsvZmxpbmtfc3RyZWFtaW5nX2ltcHVsc2Vfc291cmNlLnB5) | | |
| [...ive/messaging/interactive\_environment\_inspector.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9tZXNzYWdpbmcvaW50ZXJhY3RpdmVfZW52aXJvbm1lbnRfaW5zcGVjdG9yLnB5) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...ff4ffee](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (ff4ffee) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.42% +0.02%
==========================================
Files 469 472 +3
Lines 58736 58943 +207
==========================================
+ Hits 48988 49175 +187
- Misses 9748 9768 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/runners/portability/stager.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zdGFnZXIucHk=) | | |
| [...amples/snippets/transforms/aggregation/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9fX2luaXRfXy5weQ==) | | |
| [...teractive/testing/integration/notebook\_executor.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL25vdGVib29rX2V4ZWN1dG9yLnB5) | | |
| [...y38/build/srcs/sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| [...m/testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL21vZGVsLnB5) | | |
| [.../examples/snippets/transforms/aggregation/count.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb3VudC5weQ==) | | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | | |
| [...ild/srcs/sdks/python/apache\_beam/utils/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvX19pbml0X18ucHk=) | | |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...ff4ffee](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605239707
##########
File path: sdks/python/apache_beam/runners/interactive/caching/write_cache.py
##########
@@ -0,0 +1,170 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to write cache for PCollections being computed.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.testing import test_stream
+from apache_beam.transforms.ptransform import PTransform
+from apache_beam.transforms.window import WindowedValue
+
+
+class WriteCache:
+ """Class that facilitates writing cache for PCollections being computed.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def write_cache(self) -> None:
Review comment:
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on a change in pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #14368:
URL: https://github.com/apache/beam/pull/14368#discussion_r605238414
##########
File path: sdks/python/apache_beam/runners/interactive/caching/read_cache.py
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to read cache of computed PCollections.
+
+For internal use only; no backward-compatibility guarantees.
+"""
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+from typing import Tuple
+
+import apache_beam as beam
+from apache_beam.portability.api import beam_runner_api_pb2
+from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.caching.cacheable import Cacheable
+from apache_beam.runners.pipeline_context import PipelineContext
+from apache_beam.transforms.ptransform import PTransform
+
+
+class ReadCache:
+ """Class that facilitates reading cache of computed PCollections.
+ """
+ def __init__(
+ self,
+ pipeline: beam_runner_api_pb2.Pipeline,
+ context: PipelineContext,
+ cache_manager: cache.CacheManager,
+ cacheable: Cacheable):
+ self._pipeline = pipeline
+ self._context = context
+ self._cache_manager = cache_manager
+ self._cacheable = cacheable
+ self._key = repr(cacheable.to_key())
+ self._label = '{}{}'.format('_cache_', self._key)
+
+ def read_cache(self) -> Tuple[str, str]:
+ """Reads cache of the cacheable PCollection and wires the cache into the
+ pipeline proto. Returns the pipeline-scoped ids of the cacheable PCollection
+ and the cache reading output PCollection that replaces it.
+ """
+ template, read_output = self._build_runner_api_template()
+ output_id = self._context.pcollections.get_id(read_output)
+ source_id = self._context.pcollections.get_id(self._cacheable.pcoll)
+ # Copy cache reading subgraph from the template to the pipeline proto.
+ for pcoll_id in template.components.pcollections:
+ if pcoll_id in self._pipeline.components.pcollections:
+ continue
+ self._pipeline.components.pcollections[pcoll_id].CopyFrom(
+ template.components.pcollections[pcoll_id])
+ for coder_id in template.components.coders:
+ if coder_id in self._pipeline.components.coders:
+ continue
+ self._pipeline.components.coders[coder_id].CopyFrom(
+ template.components.coders[coder_id])
+ for windowing_strategy_id in template.components.windowing_strategies:
+ if windowing_strategy_id in \
+ self._pipeline.components.windowing_strategies:
Review comment:
Thanks, I'll apply it to everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (719318b) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49294 +87
- Misses 9723 9742 +19
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...719318b](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (ff4ffee) into [master](https://codecov.io/gh/apache/beam/commit/0e47ea3a67acbb41b8f9357d722bbd565bc74105?el=desc) (0e47ea3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ff4ffee differs from pull request most recent head 9214714. Consider uploading reports for the commit 9214714 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.40% 83.42% +0.02%
==========================================
Files 469 472 +3
Lines 58736 58943 +207
==========================================
+ Hits 48988 49175 +187
- Misses 9748 9768 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...srcs/sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | | |
| [...srcs/sdks/python/apache\_beam/io/gcp/tests/utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL3V0aWxzLnB5) | | |
| [...ache\_beam/runners/portability/local\_job\_service.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZS5weQ==) | | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjJfZ3JwYy5weQ==) | | |
| [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | | |
| [...ers/dataflow/internal/clients/dataflow/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L19faW5pdF9fLnB5) | | |
| [...hon/apache\_beam/io/gcp/datastore/v1new/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9fX2luaXRfXy5weQ==) | | |
| [...38/build/srcs/sdks/python/apache\_beam/io/avroio.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXZyb2lvLnB5) | | |
| [...sdks/python/apache\_beam/io/watermark\_estimators.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vd2F0ZXJtYXJrX2VzdGltYXRvcnMucHk=) | | |
| [...apache\_beam/examples/snippets/snippets\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvc25pcHBldHNfdGVzdF9weTMucHk=) | | |
| ... and [931 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [956c7bd...9214714](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG merged pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG merged pull request #14368:
URL: https://github.com/apache/beam/pull/14368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] KevinGG commented on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-810445694
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (719318b) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 463 453 -10
Lines 58930 59036 +106
==========================================
+ Hits 49207 49294 +87
- Misses 9723 9742 +19
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2ludGVyYWN0aXZlX3V0aWxzLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2JpZ3F1ZXJ5X3Rvcm5hZG9lcy5weQ==) | `42.10% <0.00%> (-2.90%)` | :arrow_down: |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9iaWdfcXVlcnlfcXVlcnlfdG9fdGFibGVfcGlwZWxpbmUucHk=) | `28.57% <0.00%> (-2.47%)` | :arrow_down: |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9wdWJzdWJfaXRfcGlwZWxpbmUucHk=) | `18.18% <0.00%> (-2.41%)` | :arrow_down: |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL2JpZ3F1ZXJ5L19faW5pdF9fLnB5) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...thon/apache\_beam/examples/complete/autocomplete.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2F1dG9jb21wbGV0ZS5weQ==) | `62.85% <0.00%> (-2.01%)` | :arrow_down: |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2ZpbHRlcnMucHk=) | `54.54% <0.00%> (-1.98%)` | :arrow_down: |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2NvZGVycy5weQ==) | `62.16% <0.00%> (-1.95%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npb19vdmVycmlkZXMucHk=) | `60.00% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...719318b](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (6d26c75) into [master](https://codecov.io/gh/apache/beam/commit/79578bce56eb3abc4d21a65e73cccb6ffa9173c5?el=desc) (79578bc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.49% 83.52% +0.02%
==========================================
Files 463 466 +3
Lines 58927 59135 +208
==========================================
+ Hits 49201 49392 +191
- Misses 9726 9743 +17
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3Rlc3RpbmcvdGVzdF9jYWNoZV9tYW5hZ2VyLnB5) | `92.95% <0.00%> (-1.25%)` | :arrow_down: |
| [...m/runners/portability/spark\_uber\_jar\_job\_server.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L3NwYXJrX3ViZXJfamFyX2pvYl9zZXJ2ZXIucHk=) | `85.60% <0.00%> (ø)` | |
| [...che\_beam/runners/interactive/caching/read\_cache.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2NhY2hpbmcvcmVhZF9jYWNoZS5weQ==) | `93.93% <0.00%> (ø)` | |
| [...che\_beam/runners/interactive/augmented\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2F1Z21lbnRlZF9waXBlbGluZS5weQ==) | `70.58% <0.00%> (ø)` | |
| [...he\_beam/runners/interactive/caching/write\_cache.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL2NhY2hpbmcvd3JpdGVfY2FjaGUucHk=) | `94.11% <0.00%> (ø)` | |
| [...d/srcs/sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvZnJhbWVzLnB5) | `93.25% <0.00%> (+0.02%)` | :arrow_up: |
| [...ild/srcs/sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2NvbW1vbi5weQ==) | `89.41% <0.00%> (+0.14%)` | :arrow_up: |
| [.../py38/build/srcs/sdks/python/apache\_beam/pvalue.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wdmFsdWUucHk=) | `93.12% <0.00%> (+0.38%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9kYXRhX3BsYW5lLnB5) | `91.31% <0.00%> (+1.79%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...6d26c75](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (6d26c75) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6d26c75 differs from pull request most recent head 719318b. Consider uploading reports for the commit 719318b to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.50% 83.52% +0.02%
==========================================
Files 463 466 +3
Lines 58930 59135 +205
==========================================
+ Hits 49207 49392 +185
- Misses 9723 9743 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...y38/build/srcs/sdks/python/apache\_beam/io/kafka.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2thZmthLnB5) | | |
| [...ers/dataflow/dataflow\_exercise\_metrics\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvZGF0YWZsb3cvZGF0YWZsb3dfZXhlcmNpc2VfbWV0cmljc19waXBlbGluZS5weQ==) | | |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvd29ya2VyL2RhdGFfcGxhbmUucHk=) | | |
| [...d/srcs/sdks/python/apache\_beam/ml/gcp/cloud\_dlp.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL21sL2djcC9jbG91ZF9kbHAucHk=) | | |
| [...ild/srcs/sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2ZpbGVzeXN0ZW1zLnB5) | | |
| [.../srcs/sdks/python/apache\_beam/dataframe/convert.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2RhdGFmcmFtZS9jb252ZXJ0LnB5) | | |
| [.../sdks/python/apache\_beam/transforms/deduplicate.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3RyYW5zZm9ybXMvZGVkdXBsaWNhdGUucHk=) | | |
| [...ld/srcs/sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL3RpbWVzdGFtcC5weQ==) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query1.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3Rlc3RpbmcvYmVuY2htYXJrcy9uZXhtYXJrL3F1ZXJpZXMvcXVlcnkxLnB5) | | |
| [...build/srcs/sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9nY3Npby5weQ==) | | |
| ... and [919 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...719318b](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14368: [BEAM-10708] Read/Write Intermediate PCollections
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14368:
URL: https://github.com/apache/beam/pull/14368#issuecomment-809781318
# [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=h1) Report
> Merging [#14368](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=desc) (6d26c75) into [master](https://codecov.io/gh/apache/beam/commit/b8ff8681ee9276dab23535b2d9fb5e8c85267b67?el=desc) (b8ff868) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14368 +/- ##
==========================================
+ Coverage 83.50% 83.52% +0.02%
==========================================
Files 463 466 +3
Lines 58930 59135 +205
==========================================
+ Hits 49207 49392 +185
- Misses 9723 9743 +20
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...python/apache\_beam/io/gcp/datastore/v1new/types.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9kYXRhc3RvcmUvdjFuZXcvdHlwZXMucHk=) | | |
| [...python/apache\_beam/examples/streaming\_wordcount.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL3N0cmVhbWluZ193b3JkY291bnQucHk=) | | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvcG9ydGFiaWxpdHkvbG9jYWxfam9iX3NlcnZpY2VfbWFpbi5weQ==) | | |
| [...ython/apache\_beam/io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9leHBlcmltZW50YWwvc3Bhbm5lcmlvLnB5) | | |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2xvY2FsZmlsZXN5c3RlbS5weQ==) | | |
| [...ache\_beam/examples/cookbook/datastore\_wordcount.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2Nvb2tib29rL2RhdGFzdG9yZV93b3JkY291bnQucHk=) | | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3BvcnRhYmlsaXR5L2FwaS9iZWFtX2FydGlmYWN0X2FwaV9wYjJfdXJucy5weQ==) | | |
| [...sdks/python/apache\_beam/runners/direct/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvZGlyZWN0L19faW5pdF9fLnB5) | | |
| [...am/examples/complete/juliaset/juliaset/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2p1bGlhc2V0L2p1bGlhc2V0L19faW5pdF9fLnB5) | | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3BvcnRhYmlsaXR5L2FwaS9zdGFuZGFyZF93aW5kb3dfZm5zX3BiMl91cm5zLnB5) | | |
| ... and [919 more](https://codecov.io/gh/apache/beam/pull/14368/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=footer). Last update [0805b9b...6d26c75](https://codecov.io/gh/apache/beam/pull/14368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org