[GitHub] [superset] bkyryliuk commented on a change in pull request #12535: fix(dashboard): uncaught error when loading dashboards with slices associated with deleted dataset

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #12535:
URL: https://github.com/apache/superset/pull/12535#discussion_r558549336



##########
File path: superset/models/dashboard.py
##########
@@ -236,7 +236,7 @@ def full_data(self) -> Dict[str, Any]:
             "datasources": {
                 # Filter out unneeded fields from the datasource payload
                 datasource.uid: datasource.data_for_slices(slices)
-                for datasource, slices in datasource_slices.items()
+                for datasource, slices in datasource_slices.items() if datasource

Review comment:
       @bechob please rerun black, looks like CI is failing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org