You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2006/10/07 20:12:19 UTC

[jira] Created: (OPENEJB-280) Corba classes should be in their own jar

Corba classes should be in their own jar
----------------------------------------

                 Key: OPENEJB-280
                 URL: http://issues.apache.org/jira/browse/OPENEJB-280
             Project: OpenEJB
          Issue Type: Improvement
          Components: corba
    Affects Versions: 2.2
            Reporter: David Jencks
         Assigned To: David Jencks
             Fix For: 2.2


The corba classes in openejb-core should be in their own jar.  Then that jar can be a dependency of both the yoko and sun corba integrations.  Currently yoko has to be included in the same classloader as openejb-core so that UtilDelegateImpl can load its delegate using its own classloader:

    public UtilDelegateImpl() throws ClassNotFoundException, IllegalAccessException, InstantiationException {
        String value = System.getProperty(DELEGATE_NAME);
        if (value == null) {
            log.error("No delegate specfied via " + DELEGATE_NAME);
            throw new IllegalStateException("The property " + DELEGATE_NAME + " must be defined!");
        }

        if (log.isDebugEnabled()) log.debug("Set delegate " + value);
        delegate = (UtilDelegate) Class.forName(value).newInstance();
    }


We might get some traction by using the TCCL here but I think it would be more reliable and better structure to separate the corba classes into another jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (OPENEJB-280) Corba classes should be in their own jar

Posted by "Dain Sundstrom (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OPENEJB-280?page=all ]

Dain Sundstrom closed OPENEJB-280.
----------------------------------

    Resolution: Fixed

> Corba classes should be in their own jar
> ----------------------------------------
>
>                 Key: OPENEJB-280
>                 URL: http://issues.apache.org/jira/browse/OPENEJB-280
>             Project: OpenEJB
>          Issue Type: Improvement
>          Components: corba
>    Affects Versions: 2.2
>            Reporter: David Jencks
>         Assigned To: David Jencks
>             Fix For: 2.2
>
>
> The corba classes in openejb-core should be in their own jar.  Then that jar can be a dependency of both the yoko and sun corba integrations.  Currently yoko has to be included in the same classloader as openejb-core so that UtilDelegateImpl can load its delegate using its own classloader:
>     public UtilDelegateImpl() throws ClassNotFoundException, IllegalAccessException, InstantiationException {
>         String value = System.getProperty(DELEGATE_NAME);
>         if (value == null) {
>             log.error("No delegate specfied via " + DELEGATE_NAME);
>             throw new IllegalStateException("The property " + DELEGATE_NAME + " must be defined!");
>         }
>         if (log.isDebugEnabled()) log.debug("Set delegate " + value);
>         delegate = (UtilDelegate) Class.forName(value).newInstance();
>     }
> We might get some traction by using the TCCL here but I think it would be more reliable and better structure to separate the corba classes into another jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OPENEJB-280) Corba classes should be in their own jar

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OPENEJB-280?page=comments#action_12443130 ] 
            
David Jencks commented on OPENEJB-280:
--------------------------------------

Openejb rev 465108 separates the classes and builders.  Generalizing the NamingBuilder to pass a map of information rather than just the jndi context map was necessary to write a TSSLinkBuilder.

Geronimo rev 465110 changes the NamingBuilder stuff and integrates the new jars and configs.  I don't think the new builders are fully hooked up yet.

> Corba classes should be in their own jar
> ----------------------------------------
>
>                 Key: OPENEJB-280
>                 URL: http://issues.apache.org/jira/browse/OPENEJB-280
>             Project: OpenEJB
>          Issue Type: Improvement
>          Components: corba
>    Affects Versions: 2.2
>            Reporter: David Jencks
>         Assigned To: David Jencks
>             Fix For: 2.2
>
>
> The corba classes in openejb-core should be in their own jar.  Then that jar can be a dependency of both the yoko and sun corba integrations.  Currently yoko has to be included in the same classloader as openejb-core so that UtilDelegateImpl can load its delegate using its own classloader:
>     public UtilDelegateImpl() throws ClassNotFoundException, IllegalAccessException, InstantiationException {
>         String value = System.getProperty(DELEGATE_NAME);
>         if (value == null) {
>             log.error("No delegate specfied via " + DELEGATE_NAME);
>             throw new IllegalStateException("The property " + DELEGATE_NAME + " must be defined!");
>         }
>         if (log.isDebugEnabled()) log.debug("Set delegate " + value);
>         delegate = (UtilDelegate) Class.forName(value).newInstance();
>     }
> We might get some traction by using the TCCL here but I think it would be more reliable and better structure to separate the corba classes into another jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira