You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Thomas Pocreau (Jira)" <ji...@apache.org> on 2021/09/09 09:21:00 UTC
[jira] [Updated] (BEAM-12863) BigQueryUtils doesn't process List or
Map with nullables
[ https://issues.apache.org/jira/browse/BEAM-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Pocreau updated BEAM-12863:
----------------------------------
Fix Version/s: (was: 2.30.0)
Description:
The error trace has this path (I only added the relevant ones):
a. com.google.cloud.teleport.v2.transforms.BigQueryConverters$TableRowToGenericRecordFn.apply(BigQueryConverters.java:548)
b. [org.apache.beam.sdk.io|https://org.apache.beam.sdk.io/].gcp.bigquery.BigQueryUtils.toBeamRow(BigQueryUtils.java:580)
c. [org.apache.beam.sdk.io|https://org.apache.beam.sdk.io/].gcp.bigquery.BigQueryUtils.toBeamRowFieldValue(BigQueryUtils.java:593)
d. [org.apache.beam.sdk.io|https://org.apache.beam.sdk.io/].gcp.bigquery.BigQueryUtils.toBeamValue(BigQueryUtils.java:641)
On c., a validation of null "bqValue" objects is performed; however, it appears that some of the elements are of List type (for BigQuery Record type); therefore, the List object is validated to be non-null, but not the elements of the List.
On d., the method is executed recursively to process all the elements of the List object; however, it seems that some objects are Null so this method is throwing the NullPointerExceptions.
toBeamValue method should probably not used toBeamValue recursively but toBeamRowFieldValue instead.
was:
A query with a DATETIME always returns a string with a literal T between the date and the time. The BIGQUERY_DATETIME_FORMATTER doesn't account for the literal T and won't be able
Steps to reproduce
# BigQueryIO.readTableRowsWithSchema
# Query with a DATETIME function or field. Functions will always output a literal T (https://cloud.google.com/bigquery/docs/reference/standard-sql/datetime_functions). I can't find the supporting documentation for fields though.
> BigQueryUtils doesn't process List or Map with nullables
> --------------------------------------------------------
>
> Key: BEAM-12863
> URL: https://issues.apache.org/jira/browse/BEAM-12863
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Affects Versions: 2.28.0
> Reporter: Thomas Pocreau
> Assignee: Matthew Ouyang
> Priority: P2
>
> The error trace has this path (I only added the relevant ones):
>
> a. com.google.cloud.teleport.v2.transforms.BigQueryConverters$TableRowToGenericRecordFn.apply(BigQueryConverters.java:548)
> b. [org.apache.beam.sdk.io|https://org.apache.beam.sdk.io/].gcp.bigquery.BigQueryUtils.toBeamRow(BigQueryUtils.java:580)
> c. [org.apache.beam.sdk.io|https://org.apache.beam.sdk.io/].gcp.bigquery.BigQueryUtils.toBeamRowFieldValue(BigQueryUtils.java:593)
> d. [org.apache.beam.sdk.io|https://org.apache.beam.sdk.io/].gcp.bigquery.BigQueryUtils.toBeamValue(BigQueryUtils.java:641)
>
> On c., a validation of null "bqValue" objects is performed; however, it appears that some of the elements are of List type (for BigQuery Record type); therefore, the List object is validated to be non-null, but not the elements of the List.
>
> On d., the method is executed recursively to process all the elements of the List object; however, it seems that some objects are Null so this method is throwing the NullPointerExceptions.
> toBeamValue method should probably not used toBeamValue recursively but toBeamRowFieldValue instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)