You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "andr-sokolov (via GitHub)" <gi...@apache.org> on 2025/12/30 07:54:30 UTC
[PR] Run gp_internal_tools tests [cloudberry]
andr-sokolov opened a new pull request, #1514:
URL: https://github.com/apache/cloudberry/pull/1514
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#discussion_r2730138158
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -246,7 +246,8 @@ jobs:
"gpcontrib/pxf_fdw:installcheck",
"gpcontrib/zstd:installcheck",
"gpcontrib/gp_sparse_vector:installcheck",
- "gpcontrib/gp_toolkit:installcheck"]
+ "gpcontrib/gp_toolkit:installcheck",
+ "gpcontrib/gp_internal_tools:installcheck"]
Review Comment:
If any test failed, I think we can see the regression diffs in the `ic-gpcontrib` workflow, just like this:
- https://github.com/apache/cloudberry/actions/runs/21382244420/job/61553702125.
- https://github.com/apache/cloudberry/actions/runs/21302314965/job/61380065385?pr=1514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#issuecomment-3802957754
Hi @andr-sokolov could you please resolve conflicts and rebase your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#discussion_r2938391935
##########
.github/workflows/build-cloudberry.yml:
##########
@@ -312,7 +312,8 @@ jobs:
"gpcontrib/zstd:installcheck",
"gpcontrib/gp_sparse_vector:installcheck",
"gpcontrib/gp_toolkit:installcheck",
- "gpcontrib/gp_exttable_fdw:installcheck"]
+ "gpcontrib/gp_exttable_fdw:installcheck",
Review Comment:
It seems that `gp_exttable_fdw` is for `gpfdist` and other external tables (not for PXF). So, it should be checked on cloudberry side (not pxf).
And, it is used by users, e.g. for loading data from Spark to GP/CB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#discussion_r2730138158
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -246,7 +246,8 @@ jobs:
"gpcontrib/pxf_fdw:installcheck",
"gpcontrib/zstd:installcheck",
"gpcontrib/gp_sparse_vector:installcheck",
- "gpcontrib/gp_toolkit:installcheck"]
+ "gpcontrib/gp_toolkit:installcheck",
+ "gpcontrib/gp_internal_tools:installcheck"]
Review Comment:
If any test failed, I think we can see the regression diffs in the `ic-gpcontrib` workflow, just like this: https://github.com/apache/cloudberry/actions/runs/21382244420/job/61553702125.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it commented on code in PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#discussion_r2652586303
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -246,7 +246,8 @@ jobs:
"gpcontrib/pxf_fdw:installcheck",
"gpcontrib/zstd:installcheck",
"gpcontrib/gp_sparse_vector:installcheck",
- "gpcontrib/gp_toolkit:installcheck"]
+ "gpcontrib/gp_toolkit:installcheck",
+ "gpcontrib/gp_internal_tools:installcheck"]
Review Comment:
Any regression diffs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "andr-sokolov (via GitHub)" <gi...@apache.org>.
andr-sokolov commented on code in PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#discussion_r2652648966
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -246,7 +246,8 @@ jobs:
"gpcontrib/pxf_fdw:installcheck",
"gpcontrib/zstd:installcheck",
"gpcontrib/gp_sparse_vector:installcheck",
- "gpcontrib/gp_toolkit:installcheck"]
+ "gpcontrib/gp_toolkit:installcheck",
+ "gpcontrib/gp_internal_tools:installcheck"]
Review Comment:
@my-ship-it Do you suggest to remove changes in this file, because the test is run from build-cloudberry.yml too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Run gp_internal_tools tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #1514:
URL: https://github.com/apache/cloudberry/pull/1514#discussion_r2938352166
##########
.github/workflows/build-cloudberry.yml:
##########
@@ -312,7 +312,8 @@ jobs:
"gpcontrib/zstd:installcheck",
"gpcontrib/gp_sparse_vector:installcheck",
"gpcontrib/gp_toolkit:installcheck",
- "gpcontrib/gp_exttable_fdw:installcheck"]
+ "gpcontrib/gp_exttable_fdw:installcheck",
Review Comment:
Hi @ostinru do you think there is still a necessity for running `gp_exttable_fdw` here? Would love to hear your thoughts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org