[GitHub] [superset] jinghua-qa commented on issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart

[GitBox <gi...@apache.org>]

jinghua-qa commented on issue #16403:
URL: https://github.com/apache/superset/issues/16403#issuecomment-905760813


   @geido I think your explaination make sense. But the part I feel confused is, we have 2 place can save chart change, chart property and SAVE button on data panel. In the chart property modal, name change reflected immediately but the ownership is not reflected on the SAVE modal on data panel (when I add myself as owner I am not able to overwrite and only can do 'Save as') and this PR https://github.com/apache/superset/pull/16437 can help to reduce the confusion for that.
   
   Also I think it maybe more helpful if we can make SAVE button highlight when there is unsave changed for the chart to remind user to save before leave the page. @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org