You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:09:45 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12059: refactor: WIP: Fix exhaustive-deps lint warnings

codecov-io edited a comment on pull request #12059:
URL: https://github.com/apache/incubator-superset/pull/12059#issuecomment-745427735


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=h1) Report
   > Merging [#12059](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=desc) (7f20f56) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `14.84%`.
   > The diff coverage is `36.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12059/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12059       +/-   ##
   ===========================================
   - Coverage   67.55%   52.71%   -14.85%     
   ===========================================
     Files         959      438      -521     
     Lines       47154    15765    -31389     
     Branches     4609     4072      -537     
   ===========================================
   - Hits        31857     8310    -23547     
   + Misses      15185     7455     -7730     
   + Partials      112        0      -112     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.71% <36.43%> (-0.42%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `1.44% <0.00%> (-62.51%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `4.21% <0.00%> (-46.19%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <ø> (-88.24%)` | :arrow_down: |
   | [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `1.36% <ø> (-74.72%)` | :arrow_down: |
   | [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `4.46% <0.00%> (-61.68%)` | :arrow_down: |
   | [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `5.33% <0.00%> (-69.38%)` | :arrow_down: |
   | [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | `2.29% <ø> (-75.59%)` | :arrow_down: |
   | [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `5.81% <0.00%> (-66.64%)` | :arrow_down: |
   | [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <ø> (-76.97%)` | :arrow_down: |
   | [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `2.94% <0.00%> (-67.13%)` | :arrow_down: |
   | ... and [832 more](https://codecov.io/gh/apache/incubator-superset/pull/12059/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=footer). Last update [2302adb...7f20f56](https://codecov.io/gh/apache/incubator-superset/pull/12059?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org