You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2024/07/11 19:41:13 UTC
[PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
bneradt opened a new pull request, #11539:
URL: https://github.com/apache/trafficserver/pull/11539
This addresses all the warnings in the .en.po Japanese translation of our docs so that the Sphinx docs generation builds without warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#issuecomment-2225814113
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674624090
##########
doc/locale/ja/LC_MESSAGES/admin-guide/configuration/cache-basics.en.po:
##########
@@ -915,7 +915,7 @@ msgid ""
"Edit :ts:cv:`proxy.config.http.cache.ignore_server_no_cache` in :file:"
"`records.yaml`. ::"
msgstr ""
-":file:`records.yaml` の :ts:cv:`proxy.config.http.cache."
+":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_server_no_cache`."
"ignore_server_no_cache ` を編集してください。"
Review Comment:
```suggestion
"を編集してください。"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674624896
##########
doc/locale/ja/LC_MESSAGES/admin-guide/configuration/cache-basics.en.po:
##########
@@ -915,7 +915,7 @@ msgid ""
"Edit :ts:cv:`proxy.config.http.cache.ignore_server_no_cache` in :file:"
"`records.yaml`. ::"
msgstr ""
-":file:`records.yaml` の :ts:cv:`proxy.config.http.cache."
+":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_server_no_cache`."
Review Comment:
```suggestion
":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_server_no_cache` "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674625422
##########
doc/locale/ja/LC_MESSAGES/admin-guide/configuration/cache-basics.en.po:
##########
@@ -963,7 +963,7 @@ msgid ""
"Edit :ts:cv:`proxy.config.http.cache.ignore_authentication` in :file:"
"`records.yaml`. ::"
msgstr ""
-":file:`records.yaml` の :ts:cv:`proxy.config.http.cache."
+":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_authentication`."
"ignore_authentication ` を編集してください。"
Review Comment:
```suggestion
"を編集してください。"
```
##########
doc/locale/ja/LC_MESSAGES/admin-guide/configuration/cache-basics.en.po:
##########
@@ -963,7 +963,7 @@ msgid ""
"Edit :ts:cv:`proxy.config.http.cache.ignore_authentication` in :file:"
"`records.yaml`. ::"
msgstr ""
-":file:`records.yaml` の :ts:cv:`proxy.config.http.cache."
+":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_authentication`."
Review Comment:
```suggestion
":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_authentication` "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674628180
##########
doc/locale/ja/LC_MESSAGES/admin-guide/configuration/cache-basics.en.po:
##########
@@ -915,7 +915,7 @@ msgid ""
"Edit :ts:cv:`proxy.config.http.cache.ignore_server_no_cache` in :file:"
"`records.yaml`. ::"
msgstr ""
-":file:`records.yaml` の :ts:cv:`proxy.config.http.cache."
+":file:`records.yaml` の :ts:cv:`proxy.config.http.cache.ignore_server_no_cache`."
"ignore_server_no_cache ` を編集してください。"
Review Comment:
Good catch! I missed that was wrapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674573788
##########
doc/locale/ja/LC_MESSAGES/admin-guide/storage/index.en.po:
##########
@@ -242,14 +242,14 @@ msgstr "RAM キャッシュのサイズの変更"
msgid ""
"Traffic Server provides a dedicated RAM cache for fast retrieval of popular "
"small objects. The default RAM cache size is automatically calculated based "
-"on the number and size of the :term:`cache partitions <cache partition>` "
+"on the number and size of the ``cache partitions <cache partition>`` "
"you have configured. If you've partitioned your cache according to protocol "
"and/or hosts, then the size of the RAM cache for each partition is "
"proportional to the size of that partition."
msgstr ""
"Traffic Server は人気のある小さなオブジェクトを速く取得するために専用の RAM "
-"キャッシュを提供します。デフォルトの RAM キャッシュサイズは設定した :term:`"
-"キャッシュパーティション` の数とサイズをもとに自動的に計算されます。キャッ"
+"キャッシュを提供します。デフォルトの RAM キャッシュサイズは設定した ``"
+"キャッシュパーティション`` の数とサイズをもとに自動的に計算されます。キャッ"
Review Comment:
I feel bad about this one. I couldn't figure out to how fix the `:term:` for Japanese. Thank you for trying to help, @maskit , but it still failed with your patch. This quiets the warning, but removes the `:term:` link functionality.
@maskit : if you feel motivated, can you look at this? My lack of Japanese knowledge got in the way. If we don't care much, we can go forward with my patch. It at least eliminates the warning. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674604450
##########
doc/locale/ja/LC_MESSAGES/admin-guide/storage/index.en.po:
##########
@@ -242,14 +242,14 @@ msgstr "RAM キャッシュのサイズの変更"
msgid ""
"Traffic Server provides a dedicated RAM cache for fast retrieval of popular "
"small objects. The default RAM cache size is automatically calculated based "
-"on the number and size of the :term:`cache partitions <cache partition>` "
+"on the number and size of the ``cache partitions <cache partition>`` "
"you have configured. If you've partitioned your cache according to protocol "
"and/or hosts, then the size of the RAM cache for each partition is "
"proportional to the size of that partition."
msgstr ""
"Traffic Server は人気のある小さなオブジェクトを速く取得するために専用の RAM "
-"キャッシュを提供します。デフォルトの RAM キャッシュサイズは設定した :term:`"
-"キャッシュパーティション` の数とサイズをもとに自動的に計算されます。キャッ"
+"キャッシュを提供します。デフォルトの RAM キャッシュサイズは設定した ``"
+"キャッシュパーティション`` の数とサイズをもとに自動的に計算されます。キャッ"
Review Comment:
If the change on glossary.en.po doesn't work, I think it's a limitation... On glossary.en.rst, "cache partition" is not only a visible string but also an anchor name. I guess Sphinx is confused by that. I don't mind removing `:term:`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Japanese translation Sphinx docs warnings [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11539:
URL: https://github.com/apache/trafficserver/pull/11539#discussion_r1674587648
##########
doc/locale/ja/LC_MESSAGES/admin-guide/storage/index.en.po:
##########
@@ -242,14 +242,14 @@ msgstr "RAM キャッシュのサイズの変更"
msgid ""
"Traffic Server provides a dedicated RAM cache for fast retrieval of popular "
"small objects. The default RAM cache size is automatically calculated based "
-"on the number and size of the :term:`cache partitions <cache partition>` "
+"on the number and size of the ``cache partitions <cache partition>`` "
"you have configured. If you've partitioned your cache according to protocol "
"and/or hosts, then the size of the RAM cache for each partition is "
"proportional to the size of that partition."
msgstr ""
"Traffic Server は人気のある小さなオブジェクトを速く取得するために専用の RAM "
-"キャッシュを提供します。デフォルトの RAM キャッシュサイズは設定した :term:`"
-"キャッシュパーティション` の数とサイズをもとに自動的に計算されます。キャッ"
+"キャッシュを提供します。デフォルトの RAM キャッシュサイズは設定した ``"
+"キャッシュパーティション`` の数とサイズをもとに自動的に計算されます。キャッ"
Review Comment:
This can be reproduced locally like so:
```sh
cmake -B docbuild -DDOC_LANG:STRING=ja -DENABLE_DOCS=ON
cmake --build docbuild --target generate_docs -j10
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org