You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by nc...@apache.org on 2026/10/09 09:56:28 UTC
(spark) branch branch-4.x updated: [SPARK-59327][BUILD] Add config test module
This is an automated email from the ASF dual-hosted git repository.
nchammas pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new 175405f00279 [SPARK-59327][BUILD] Add config test module
175405f00279 is described below
commit 175405f00279bab52c0df514b04aaf9653a4e13c
Author: Nicholas Chammas <ni...@gmail.com>
AuthorDate: Fri Oct 9 12:56:01 2026 +0300
[SPARK-59327][BUILD] Add config test module
### What changes were proposed in this pull request?
Add a new `config` test module that runs the `config/test` sbt goal (which runs `ConfigRegistrySuite`).
### Why are the changes needed?
When this new suite was added in #53488 I believe it was left out of the test modules by mistake.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Confirmed that `ConfigRegistrySuite` now [runs on CI][1].
[1]: https://github.com/nchammas/spark/actions/runs/34184737093/job/101933969437#step:12:397
### Was this patch authored or co-authored using generative AI tooling?
I wrote this patch with assistance from GitHub Copilot.
Closes #58587 from nchammas/config-test-module.
Authored-by: Nicholas Chammas <ni...@gmail.com>
Signed-off-by: Nicholas Chammas <ni...@gmail.com>
(cherry picked from commit 670927a20faee83e81f5857e74c71f4d184b2415)
Signed-off-by: Nicholas Chammas <ni...@gmail.com>
---
.github/workflows/build_and_test.yml | 8 ++++----
.github/workflows/maven_test.yml | 2 +-
dev/sparktestsupport/modules.py | 13 ++++++++++++-
3 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 7f57f24182f5..3f3072eff2bd 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -151,8 +151,8 @@ jobs:
java17=false
java25=false
fi
- build=`./dev/is-changed.py -m "core,unsafe,kvstore,avro,utils,utils-java,network-common,network-shuffle,repl,launcher,examples,sketch,variant,api,catalyst,hive-thriftserver,mllib-local,mllib,graphx,streaming,sql-kafka-0-10,streaming-kafka-0-10,streaming-kinesis-asl,credential-aws,kubernetes,hadoop-cloud,spark-ganglia-lgpl,profiler,protobuf,yarn,connect,sql,hive,pipelines"`
- build_core_utils=`./dev/is-changed.py -m "core,unsafe,kvstore,utils,utils-java,network-common,network-shuffle,sketch,variant,launcher"`
+ build=`./dev/is-changed.py -m "core,unsafe,kvstore,avro,utils,utils-java,config,network-common,network-shuffle,repl,launcher,examples,sketch,variant,api,catalyst,hive-thriftserver,mllib-local,mllib,graphx,streaming,sql-kafka-0-10,streaming-kafka-0-10,streaming-kinesis-asl,credential-aws,kubernetes,hadoop-cloud,spark-ganglia-lgpl,profiler,protobuf,yarn,connect,sql,hive,pipelines"`
+ build_core_utils=`./dev/is-changed.py -m "core,unsafe,kvstore,utils,utils-java,config,network-common,network-shuffle,sketch,variant,launcher"`
precondition="
{
\"build\": \"$build\",
@@ -272,7 +272,7 @@ jobs:
# Note that the modules below are from sparktestsupport/modules.py.
modules:
- >-
- core, unsafe, kvstore, utils, utils-java,
+ core, unsafe, kvstore, utils, utils-java, config,
network-common, network-shuffle, sketch, variant, launcher
- >-
api, catalyst, hive-thriftserver
@@ -324,7 +324,7 @@ jobs:
# Skip the core/utils group when a PR doesn't touch those modules (e.g. SQL-only or
# PySpark-only changes). The precondition is opt-out: omitted means run (so periodic
# full-build workflows that set only "build": "true" keep running this entry).
- - modules: ${{ fromJson(needs.precondition.outputs.required).build-core-utils == 'false' && 'core, unsafe, kvstore, utils, utils-java, network-common, network-shuffle, sketch, variant, launcher' }}
+ - modules: ${{ fromJson(needs.precondition.outputs.required).build-core-utils == 'false' && 'core, unsafe, kvstore, utils, utils-java, config, network-common, network-shuffle, sketch, variant, launcher' }}
env:
MODULES_TO_TEST: ${{ matrix.modules }}
EXCLUDED_TAGS: ${{ matrix.excluded-tags }}
diff --git a/.github/workflows/maven_test.yml b/.github/workflows/maven_test.yml
index b409caf2cfe0..10c070a7c78a 100644
--- a/.github/workflows/maven_test.yml
+++ b/.github/workflows/maven_test.yml
@@ -154,7 +154,7 @@ jobs:
- hive2.3
modules:
- >-
- core,launcher,common#unsafe,common#kvstore,common#network-common,common#network-shuffle,common#sketch,common#utils,common#utils-java,common#variant
+ core,launcher,common#unsafe,common#kvstore,common#network-common,common#network-shuffle,common#sketch,common#utils,common#utils-java,common#config,common#variant
- >-
graphx,streaming,hadoop-cloud
- >-
diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py
index cb964c62d437..b8111c9b6958 100644
--- a/dev/sparktestsupport/modules.py
+++ b/dev/sparktestsupport/modules.py
@@ -216,6 +216,17 @@ tags = Module(
],
)
+config = Module(
+ name="config",
+ dependencies=[tags],
+ source_file_regexes=[
+ "common/config/",
+ ],
+ sbt_test_goals=[
+ "config/test",
+ ],
+)
+
utils_java = Module(
name="utils-java",
dependencies=[tags],
@@ -229,7 +240,7 @@ utils_java = Module(
utils = Module(
name="utils",
- dependencies=[tags, utils_java],
+ dependencies=[tags, utils_java, config],
source_file_regexes=[
"common/utils/",
],
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org