You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/16 04:46:28 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39590: [SPARK-42079][CONNECT][PYTHON] Rename proto messages for `toDF` and `withColumnsRenamed`
zhengruifeng opened a new pull request, #39590:
URL: https://github.com/apache/spark/pull/39590
### What changes were proposed in this pull request?
Rename proto messages for `toDF` and `withColumnsRenamed`
### Why are the changes needed?
to be consistent with other messages: we usually name the proto messages after the corresponding logical plan or dataframe API.
### Does this PR introduce _any_ user-facing change?
no, dev-only
### How was this patch tested?
existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39590: [SPARK-42079][CONNECT][PYTHON] Rename proto messages for `toDF` and `withColumnsRenamed`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39590:
URL: https://github.com/apache/spark/pull/39590#issuecomment-1384688152
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39590: [SPARK-42079][CONNECT][PYTHON] Rename proto messages for `toDF` and `withColumnsRenamed`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39590: [SPARK-42079][CONNECT][PYTHON] Rename proto messages for `toDF` and `withColumnsRenamed`
URL: https://github.com/apache/spark/pull/39590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org