You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 12:29:06 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #22939: Fix regression in pool metrics

uranusjr commented on code in PR #22939:
URL: https://github.com/apache/airflow/pull/22939#discussion_r848377648


##########
airflow/jobs/scheduler_job.py:
##########
@@ -369,6 +369,9 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session =
                     starved_pools.add(pool_name)
                     continue
 
+                # Make sure to emit metrics if pool has no starving tasks
+                pool_num_starving_tasks[pool_name] += 0

Review Comment:
   The `+= 0` part looks so much like a bug, we should do something to make it less so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org