You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2010/07/13 08:33:50 UTC

[jira] Created: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

[classlib][nio] SocketChannel.write eat more bytes than expected.
-----------------------------------------------------------------

                 Key: HARMONY-6580
                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
             Project: Harmony
          Issue Type: Bug
            Reporter: Li Jing Qin


SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Jing Qin updated HARMONY-6580:
---------------------------------

    Attachment: HARMONY-6580.diff

The test case is: Given a very big byte buffer which will not been sent totally by the channel, the remaining bytes calculation is wrong, because the remaining() will always return 0 after we set the position to the limit.

> [classlib][nio] SocketChannel.write eat more bytes than expected.
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6580
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>         Attachments: HARMONY-6580.diff
>
>
> SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-6580:
------------------------------------

    Assignee: Tim Ellison

> [classlib][nio] SocketChannel.write eat more bytes than expected.
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6580
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>         Attachments: HARMONY-6580.diff
>
>
> SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Jing Qin closed HARMONY-6580.
--------------------------------


Verified. Thanks Tim.

> [classlib][nio] SocketChannel.write eat more bytes than expected.
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6580
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6580.diff
>
>
> SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888099#action_12888099 ] 

Hudson commented on HARMONY-6580:
---------------------------------

Integrated in Harmony-select-1.5-head-linux-x86_64 #61 (See [http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/61/])
    Apply slightly modified patch for HARMONY-6580 ([classlib][nio] SocketChannel.write eat more bytes than expected)


> [classlib][nio] SocketChannel.write eat more bytes than expected.
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6580
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6580.diff
>
>
> SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888058#action_12888058 ] 

Hudson commented on HARMONY-6580:
---------------------------------

Integrated in Harmony-1.5-head-linux-x86_64 #888 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/888/])
    Apply slightly modified patch for HARMONY-6580 ([classlib][nio] SocketChannel.write eat more bytes than expected)


> [classlib][nio] SocketChannel.write eat more bytes than expected.
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6580
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6580.diff
>
>
> SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6580) [classlib][nio] SocketChannel.write eat more bytes than expected.

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-6580.
----------------------------------

    Fix Version/s: 5.0M15
       Resolution: Fixed

Thanks Charles, good catch on this one!

Patch applied to NIO module at repo revision r963690.

I modified the test case slightly to use a system provided port during the bind rather than using the deprecated local address fields, this will make the test more stable.  I also dropped the send buffer size suggestion to potentially reduce mem usage.

Please verify the patch was applied as you expected.



> [classlib][nio] SocketChannel.write eat more bytes than expected.
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6580
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6580
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6580.diff
>
>
> SocketChannel fail to compute the right bytesRemaining. This cause eating more bytes from the buffer than expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.