[GitHub] incubator-trafodion pull request: Fix JIRA 1503

[nonstop-qfchen <gi...@git.apache.org>]

GitHub user nonstop-qfchen opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/100

    Fix JIRA 1503

    This is to fix JIRA 1503. 
    
    The code change involves rewinding the ComDiags area including the maxDiagsId_ data member. Without doing so, maxDiagsId_ becomes out of sync with # of errors and # of warnings and lead to the test "da->getNumber() != daMark" to fail. With the fix, da->mark() call returns a value of 0, a good starting point to detect any potential errors. 
    
    GenExpGenerator.cpp:
    
      daMark = da->mark();
      ex_expr::exp_return_type evalReturnCode = defaultValueIdList.evalAtCompileTime
        (0,
         ExpTupleDesc::PACKED_FORMAT,
         defaultValue, attr->getDefaultValueStorageLength() + extraFltLen,
         &length, &offset, da);
    
      if ((evalReturnCode != ex_expr::EXPR_OK) || (da->getNumber() != daMark))

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nonstop-qfchen/incubator-trafodion hivePartFunc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit 276da699f3695c5d9cd113c9c370a6d1a8fc7fc3
Author: Qifan Chen <qf...@dev02.trafodion.org>
Date:   2015-10-02T13:41:30Z

    fix JIRA 1503

commit f27bc255357b1913d40d4b06303e5dd14ca10d7b
Author: Qifan Chen <qf...@dev02.trafodion.org>
Date:   2015-10-02T13:41:51Z

    Merge remote branch 'github/master' into hivePartFunc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Fix JIRA 1503

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---