You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/24 01:24:00 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14373: [Flaky-test] Fix metadata cache flaky tests

codelipenghui commented on a change in pull request #14373:
URL: https://github.com/apache/pulsar/pull/14373#discussion_r813470398



##########
File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataCacheTest.java
##########
@@ -233,7 +234,7 @@ public void insertionDeletionWitGenericType(String provider, Supplier<String> ur
         v.put("b", "2");
         objCache.create(key1, v).join();
 
-        assertEquals(objCache.getIfCached(key1), Optional.of(v));
+        assertEqualsAndRetry(() -> objCache.getIfCached(key1), Optional.of(v), Optional.empty());

Review comment:
       Can we use the Awaitibility to instread?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org