You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Benoit Tellier (Jira)" <se...@james.apache.org> on 2021/09/04 10:51:00 UTC

[jira] [Commented] (JAMES-1130) Make it possible to share MimeMessageSource till the message body needs to get altered

    [ https://issues.apache.org/jira/browse/JAMES-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409936#comment-17409936 ] 

Benoit Tellier commented on JAMES-1130:
---------------------------------------

See https://issues.apache.org/jira/browse/JAMES-3477

The resulting code turned out not to be thread safe, resulting in unpredictable NullPointerExceptions when accessing the message body.

We defaulted to defensive copies.

Regards,

> Make it possible to share MimeMessageSource till the message body needs to get altered
> --------------------------------------------------------------------------------------
>
>                 Key: JAMES-1130
>                 URL: https://issues.apache.org/jira/browse/JAMES-1130
>             Project: James Server
>          Issue Type: Improvement
>          Components: James Core
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>            Priority: Major
>             Fix For: 3.0.0
>
>
> At the moment as soon as the message content needs to get altered we "copy" the whole MimeMessage (when it is shared between Mail instances). Thats a waste of resources, when only the headers are modified (which is the case most of the time). We should better copy the headers into memory if needed and do the modification there. Then when write back the MimeMessage into the queue/store/etc we would just read the headers from memory and skip to read them from the MimeMessageSource. 
> That would be a way more efficient,



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org