You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/29 23:23:33 UTC
[GitHub] [pulsar] merlimat opened a new pull request #7105: Fixed KeyShared consumers getting stuck on delivery
merlimat opened a new pull request #7105:
URL: https://github.com/apache/pulsar/pull/7105
Note: this is based on top of #6791 & #7104. Once these are merged, I'll rebase here. For the sake of this review, check commit 23d6dcb7
### Motivation
If one consumer is slowly processing messages, this can prevent other consumers from making progress on the topic. Instead we're in a loop of keep trying to replay messages without being able to dispatch any message.
The basic idea here is that we can make progress by keep going through the topic and dispatch these messages to the consumers that are free, at least the keys that belong to them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7105: Fixed KeyShared consumers getting stuck on delivery
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7105:
URL: https://github.com/apache/pulsar/pull/7105#issuecomment-638946119
@merlimat The broker unit test is so hard to get passed. I'm creating a PR to split the whole broker unit test into multiple parts and fixed some flaky tests. Please take a look at #7173.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7105: Fixed KeyShared consumers getting stuck on delivery
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7105:
URL: https://github.com/apache/pulsar/pull/7105#issuecomment-638842080
@merlimat Would you please help rebase this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7105: Fixed KeyShared consumers getting stuck on delivery
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7105:
URL: https://github.com/apache/pulsar/pull/7105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org