[jira] [Commented] (OPENNLP-1010) NaiveBayes serialized models are not working

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968512#comment-15968512 ] 

ASF GitHub Bot commented on OPENNLP-1010:
-----------------------------------------

GitHub user wcolen opened a pull request:

    https://github.com/apache/opennlp/pull/154

    OPENNLP-1010: Fix NaiveBayes model writer

    The previous sortValues method was based on Perceptron, but for some reason it was not working
    for NaiveBayes. Changed it to the one from GIS fixed it.
    
    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wcolen/opennlp OPENNLP-1010

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 7f738f55a27a0f13138ba9b24961d08b28df2048
Author: William D C M SILVA <co...@apache.org>
Date:   2017-04-14T02:07:12Z

    OPENNLP-1010: Fix NaiveBayes model writer
    
    The previous sortValues method was based on Perceptron, but for some reason it was not working
    for NaiveBayes. Changed it to the one from GIS fixed it.

----


> NaiveBayes serialized models are not working
> --------------------------------------------
>
>                 Key: OPENNLP-1010
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1010
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Machine Learning
>    Affects Versions: 1.7.2
>            Reporter: William Colen
>         Attachments: NaiveBayesSerializedCorrectnessTest.java
>
>
> The behaviour of a serialized model is different from a model that was never serialized. For example, sometimes using the serialized we get only one outcome, while it was working perfectly during cross validation (when we use it before serializing).
> The attached test reproduces it. It compares the outcome array of a model that was never serialized and the same model that was serialized and loaded.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)