[GitHub] [hadoop] goiri commented on a change in pull request #3613: HDFS-16296. RouterRpcFairnessPolicyController add rejected permits for each nameservice

[GitBox <gi...@apache.org>]

goiri commented on a change in pull request #3613:
URL: https://github.com/apache/hadoop/pull/3613#discussion_r742196019



##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/fairness/TestRouterHandlersFairness.java
##########
@@ -208,4 +212,15 @@ private void invokeConcurrent(ClientProtocol routerProto, String clientName)
     routerProto.renewLease(clientName);
   }
 
+  private int getTotalRejectedPermits(RouterContext routerContext) {
+    int totalRejectedPermits = 0;
+    for (String ns : cluster.getNameservices()) {
+      totalRejectedPermits += routerContext.getRouter().getRpcServer()

Review comment:
       We may want to extract:
   routerContext.getRouter().getRpcServer().getRPCClient()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org