[GitHub] [cloudstack] smlshn opened a new pull request #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard

[GitBox <gi...@apache.org>]

smlshn opened a new pull request #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard
URL: https://github.com/apache/cloudstack/pull/3336
 
 
   
   ## Description
   Adds functionality to sort the data that is available on each in the deploy VM wizard's step by their suitable fields i.e
   - templates by name
   - serviceOfferings by cpuspeed
   - diskOfferings by disksize
   - affinityGroups by name
   - sshkeyPairs by name
   - network:
      - vpcs by name
      - networkOfferings by name
   
   Fixes: https://github.com/apache/cloudstack/issues/3050
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   - sorted compute offerings
   <img width="480" alt="Screen Shot 2019-05-18 at 02 24 53" src="https://user-images.githubusercontent.com/8104993/57960951-8b9ade00-7914-11e9-8780-cda1593a510a.png">
   
   - sorted disk offerings
   <img width="457" alt="Screen Shot 2019-05-18 at 02 24 58" src="https://user-images.githubusercontent.com/8104993/57960967-96ee0980-7914-11e9-86bd-8ac4394e0336.png">
   
   - sorted networks
   <img width="446" alt="Screen Shot 2019-05-18 at 02 25 09" src="https://user-images.githubusercontent.com/8104993/57960972-9b1a2700-7914-11e9-8232-90b4a6670c67.png">
   
   ## How Has This Been Tested?
   Run client
   Instances > Add Instance
   See previous non sorted data in the browser's console
   After sort function run see sorted data in the browser's console
   See sorted results in the deploy VM wizard as well
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services