[GitHub] [pinot] agavra commented on a diff in pull request #9927: [DRAFT] check aggregate functions for type safety before running query

[GitBox <gi...@apache.org>]

agavra commented on code in PR #9927:
URL: https://github.com/apache/pinot/pull/9927#discussion_r1041679689


##########
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java:
##########
@@ -235,6 +236,10 @@ private void applyQueryOptions(QueryContext queryContext) {
 
   @Override
   public PlanNode makeSegmentPlanNode(IndexSegment indexSegment, QueryContext queryContext) {
+    ExpressionTypeResolver validator =
+        new ExpressionTypeResolver(indexSegment, queryContext);
+    queryContext.getSelectExpressions().forEach(ec -> ec.visit(validator));

Review Comment:
   Review Note: I didn't spend much time figuring out where to plug this in, this is definitely not an ideal place - just the easiest to prove that the approach works



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org