[GitHub] [pinot] nizarhejazi commented on a diff in pull request #8622: Support BigDecimal raw value forward index; Support BigDecimal in many transforms and operators

[GitBox <gi...@apache.org>]

nizarhejazi commented on code in PR #8622:
URL: https://github.com/apache/pinot/pull/8622#discussion_r863836030


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -374,6 +374,7 @@ public static void persistCreationMeta(File indexDir, long crc, long creationTim
   void buildIndexCreationInfo()
       throws Exception {
     Set<String> varLengthDictionaryColumns = new HashSet<>(_config.getVarLengthDictionaryColumns());
+    Set<String> rawIndexCreationColumns = _config.getRawIndexCreationColumns();

Review Comment:
   Yes, "`createDictionary` flag is not checked", and instead `getColumnCompressionType(segmentCreationSpec, fieldSpec)` is called to check for dict columns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org