You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/01/09 18:16:05 UTC
[kudu-CR] [build] Fix IWYU dependencies
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14995
Change subject: [build] Fix IWYU dependencies
......................................................................
[build] Fix IWYU dependencies
IWYU is failing with a missing `version_defines.h`. This patch
fixes the dependency chain by adding `gen_version_info`
to the iwyu and tidy target.
Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/14995/1
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix IWYU dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14995
to look at the new patch set (#2).
Change subject: [build] Fix IWYU dependencies
......................................................................
[build] Fix IWYU dependencies
IWYU is failing with a missing `version_defines.h`. This patch
fixes the dependency chain by adding `gen_version_info`
to the generated-headers target. This ensures it’s run
for the iwyu and tidy targets.
Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/14995/2
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix IWYU dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14995 )
Change subject: [build] Fix IWYU dependencies
......................................................................
[build] Fix IWYU dependencies
IWYU is failing with a missing `version_defines.h`. This patch
fixes the dependency chain by adding `gen_version_info`
to the generated-headers target. This ensures it’s run
for the iwyu and tidy targets.
Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Reviewed-on: http://gerrit.cloudera.org:8080/14995
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix IWYU dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14995 )
Change subject: [build] Fix IWYU dependencies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Jan 2020 19:07:54 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix IWYU dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14995 )
Change subject: [build] Fix IWYU dependencies
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14995/1/CMakeLists.txt
File CMakeLists.txt:
PS1:
> I think gen_version_info should be a dependency of generated-headers rather
IWYU works for me without this fix.
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Jan 2020 18:44:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix IWYU dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14995 )
Change subject: [build] Fix IWYU dependencies
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14995/1/CMakeLists.txt
File CMakeLists.txt:
PS1:
I think gen_version_info should be a dependency of generated-headers rather than of iwyu, iwyu-fix, and tidy. It is a "generated header" after all.
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Jan 2020 18:30:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix IWYU dependencies
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14995 )
Change subject: [build] Fix IWYU dependencies
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14995/1/CMakeLists.txt
File CMakeLists.txt:
PS1:
> IWYU works for me without this fix.
Just re-checked with changes in master-test.cc and found it indeed breaks.
+1 to Adar's suggestion: it's better to put the gen_version_info into the generated-headers target.
Thanks for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Jan 2020 19:07:40 +0000
Gerrit-HasComments: Yes