You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/09/03 01:03:42 UTC

Review Request 25276: SQOOP-1487: Sqoop2: From/To: Refactor/Create HDFS connector test cases

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25276/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1487
    https://issues.apache.org/jira/browse/SQOOP-1487


Repository: sqoop-SQOOP-1367


Description
-------

commit ef720b45ceee746462bdf95c65aca7ac1428ccb2
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Tue Sep 2 16:00:45 2014 -0700

    SQOOP-1487: Sqoop2: From/To: Refactor/Create HDFS connector test cases

:100644 100644 8df9f11... fa4330a... M  connector/connector-hdfs/pom.xml
:100644 100644 fc12381... 7447071... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
:000000 100644 0000000... 8c19d01... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/FileUtils.java
:000000 100644 0000000... 6ed4087... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
:000000 100644 0000000... 0cc2b8b... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
:000000 100644 0000000... 79cf1f1... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
:000000 100644 0000000... ae93b0a... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
:000000 100644 0000000... 44ffced... A  connector/connector-hdfs/src/test/resources/log4j.properties
:100644 000000 e685883... 0000000... D  execution/mapreduce/src/test/java/org/apache/sqoop/job/FileUtils.java
:100644 000000 2accf77... 0000000... D  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java
:100644 000000 8eba049... 0000000... D  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java


Diffs
-----

  connector/connector-hdfs/pom.xml 8df9f11 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java fc12381 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/FileUtils.java PRE-CREATION 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java PRE-CREATION 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java PRE-CREATION 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java PRE-CREATION 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java PRE-CREATION 
  connector/connector-hdfs/src/test/resources/log4j.properties PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/FileUtils.java e685883 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java 2accf77 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 8eba049 

Diff: https://reviews.apache.org/r/25276/diff/


Testing
-------

Ran HDFS Connector test cases.


Thanks,

Abraham Elmahrek


Re: Review Request 25276: SQOOP-1487: Sqoop2: From/To: Refactor/Create HDFS connector test cases

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25276/#review52148
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Sept. 2, 2014, 11:03 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25276/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 11:03 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1487
>     https://issues.apache.org/jira/browse/SQOOP-1487
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> commit ef720b45ceee746462bdf95c65aca7ac1428ccb2
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Sep 2 16:00:45 2014 -0700
> 
>     SQOOP-1487: Sqoop2: From/To: Refactor/Create HDFS connector test cases
> 
> :100644 100644 8df9f11... fa4330a... M  connector/connector-hdfs/pom.xml
> :100644 100644 fc12381... 7447071... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :000000 100644 0000000... 8c19d01... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/FileUtils.java
> :000000 100644 0000000... 6ed4087... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :000000 100644 0000000... 0cc2b8b... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :000000 100644 0000000... 79cf1f1... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> :000000 100644 0000000... ae93b0a... A  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
> :000000 100644 0000000... 44ffced... A  connector/connector-hdfs/src/test/resources/log4j.properties
> :100644 000000 e685883... 0000000... D  execution/mapreduce/src/test/java/org/apache/sqoop/job/FileUtils.java
> :100644 000000 2accf77... 0000000... D  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java
> :100644 000000 8eba049... 0000000... D  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/pom.xml 8df9f11 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java fc12381 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/FileUtils.java PRE-CREATION 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java PRE-CREATION 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java PRE-CREATION 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java PRE-CREATION 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java PRE-CREATION 
>   connector/connector-hdfs/src/test/resources/log4j.properties PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/FileUtils.java e685883 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java 2accf77 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 8eba049 
> 
> Diff: https://reviews.apache.org/r/25276/diff/
> 
> 
> Testing
> -------
> 
> Ran HDFS Connector test cases.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>