[GitHub] [pulsar] eolivelli commented on a change in pull request #9815: [CI] Add apache-rat check in Ci

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9815:
URL: https://github.com/apache/pulsar/pull/9815#discussion_r588121754



##########
File path: .github/workflows/ci-license.yaml
##########
@@ -78,3 +78,13 @@ jobs:
       - name: license check
         if: steps.docs.outputs.changed_only == 'no'
         run: src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz
+
+      - name: license headers check in src package
+        if: steps.docs.outputs.changed_only == 'no'
+        run: |
+          version=`src/get-project-version.py`
+          cd distribution/server/target
+          tar -xf apache-pulsar-${version}-src.tar.gz
+          cd apache-pulsar-${version}
+          mvn apache-rat:check

Review comment:
       you do not need to make this here.
   
   you should run it during the initial build
   
   running it against the source distro is okay, but we also MUST be complaint on the bare git repo.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org