[jira] [Commented] (FLINK-8859) RocksDB backend should pass WriteOption to Rocks.put() when restoring

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386012#comment-16386012 ] 

ASF GitHub Bot commented on FLINK-8859:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5635

    [FLINK-8859][state backend] RocksDB backend should pass WriteOption to Rocks.put() when restoring

    ## What is the purpose of the change
    
    This PR fixes [FLINK-8859](https://issues.apache.org/jira/browse/FLINK-8859). We should pass `WriteOption` to Rocks.put() when restoring from handle (Both in full & incremental checkpoint). Because of `WriteOption.setDisableWAL(true)`, the performance can be increased by about 2 times.
    
    ## Brief change log
    
      - pass WriteOption to Rocks.put() when restoring
    
    ## Verifying this change
    The changes can be verified by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink pass_writeoption_2_put

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5635
    
----
commit 08109cb20d26bd1c8a04455b2fa914807a730a28
Author: sihuazhou <su...@...>
Date:   2018-03-05T12:21:27Z

    Pass the WriteOption to RocksDB.put() when restoring from handle.

----


> RocksDB backend should pass WriteOption to Rocks.put() when restoring
> ---------------------------------------------------------------------
>
>                 Key: FLINK-8859
>                 URL: https://issues.apache.org/jira/browse/FLINK-8859
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should pass `WriteOption` to Rocks.put() when restoring from handle (Both in full & incremental checkpoint). Because of `WriteOption.setDisableWAL(true)`, the performance can be increased by about 2 times.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)