You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/10 07:15:12 UTC

[GitHub] [flink] zhijiangW commented on issue #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

zhijiangW commented on issue #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService
URL: https://github.com/apache/flink/pull/8133#issuecomment-481564984
 
 
   @azagrebin I ever thought that unifying the close of partition/gate with canceler process, but it seems a bit different during handling exception, so just make them independent as now.
   
   In addition, I am not sure why the previous implementation only catches exception for gate close, and the partition close might also cause exception. So I just refactored the processes and kept the behavior as before to not change anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services