You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "liuneng1994 (via GitHub)" <gi...@apache.org> on 2024/04/23 06:18:48 UTC

[PR] [CH] Speed up mergetree metadata reloading [incubator-gluten]

liuneng1994 opened a new pull request, #5498:
URL: https://github.com/apache/incubator-gluten/pull/5498

   ## What changes were proposed in this pull request?
   
   Speed up mergetree metadata reloading. The principle is to increase the writing speed of metadata through the thread pool.
   The default thread pool size is minimum 10, which can be specified through `spark.gluten.sql.columnar.backend.ch.runtimesettings.max_threads`
   
   ```
   2000+parts
   before:
   runTPCHQueryBySQL cost time: 136886 ms
   after:
   runTPCHQueryBySQL cost time: 12017 ms
   ```
   
   ## How was this patch tested?
   
   manual tests
   
   
   (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [CH] Speed up mergetree metadata reloading [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5498:
URL: https://github.com/apache/incubator-gluten/pull/5498#issuecomment-2071491422

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [CH] Speed up mergetree metadata reloading [incubator-gluten]

Posted by "loneylee (via GitHub)" <gi...@apache.org>.
loneylee commented on PR #5498:
URL: https://github.com/apache/incubator-gluten/pull/5498#issuecomment-2071806027

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [CH] Speed up mergetree metadata reloading [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5498:
URL: https://github.com/apache/incubator-gluten/pull/5498#issuecomment-2071491104

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICEGJ-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** in the following format?
   
       [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [CH] Speed up mergetree metadata reloading [incubator-gluten]

Posted by "liuneng1994 (via GitHub)" <gi...@apache.org>.
liuneng1994 merged PR #5498:
URL: https://github.com/apache/incubator-gluten/pull/5498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org