[GitHub] [spark] Yikun commented on a diff in pull request #37005: [SPARK-39522][INFRA]Uses Docker image cache over a custom image in pyspark job

[GitBox <gi...@apache.org>]

Yikun commented on code in PR #37005:
URL: https://github.com/apache/spark/pull/37005#discussion_r914420987


##########
.github/workflows/build_and_test.yml:
##########
@@ -805,3 +853,27 @@ jobs:
       with:
         name: unit-tests-log-docker-integration--8-${{ inputs.hadoop }}-hive2.3
         path: "**/target/unit-tests.log"
+
+  # Note that: there are only GHCR creation permission for secrets.GITHUB_TOKEN
+  # If you want to clean up the CI images, you need to:
+  # - 1. Generate the token from https://github.com/settings/tokens with `write:packages` and `delete:packages`
+  # - 2. Add the the token as secrets `GHCR_DEL` in https://github.com/{username}}/spark/settings/secrets/actions
+  infra-image-post:
+    # Always runs after pyspark/sparkr/lint have completed, regardless of whether they were successful
+    if: always()
+    needs: [pyspark, sparkr, lint]
+    runs-on: ubuntu-20.04
+    env:
+      GHCR_DEL: ${{ secrets.GHCR_DEL }}

Review Comment:
   https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow
   
   need to define secrets in main workflow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org