You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sangeetha hariharan <sa...@citrix.com> on 2014/06/18 03:37:23 UTC

Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/
-----------------------------------------------------------

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
-------

This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users


Diffs
-----

  test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22712/diff/


Testing
-------

Test Suite was executed against a management server built from 4.4-forward branch using a simulator set up:
test_deleteNetwork_admin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_forcrossdomainuser (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsubdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : SUCCESS ===
ok
test_deleteNetwork_user (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 10 tests in 61.766s

OK


Thanks,

sangeetha hariharan


Re: Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/#review52760
-----------------------------------------------------------


Please change method comments to use one docstrings style instead of mixing them with single-line comments.

- Min Chen


On Sept. 8, 2014, 7:52 p.m., sangeetha hariharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22712/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 7:52 p.m.)
> 
> 
> Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22712/diff/
> 
> 
> Testing
> -------
> 
> Test Suite was executed against a management server built from 4.4-forward branch using a simulator set up:
> test_deleteNetwork_admin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
> ok
> test_deleteNetwork_admin_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_admin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin_forcrossdomainuser (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin_foruserinsubdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_user (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
> ok
> test_deleteNetwork_user_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_user_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 61.766s
> 
> OK
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>


Re: Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/#review52787
-----------------------------------------------------------

Ship it!


Ship It!

- Min Chen


On Sept. 9, 2014, 8:39 p.m., sangeetha hariharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22712/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 8:39 p.m.)
> 
> 
> Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22712/diff/
> 
> 
> Testing
> -------
> 
> Test Suite was executed against a management server built from 4.4-forward branch using a simulator set up:
> test_deleteNetwork_admin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
> ok
> test_deleteNetwork_admin_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_admin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin_forcrossdomainuser (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_domaindmin_foruserinsubdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_user (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
> ok
> test_deleteNetwork_user_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : SUCCESS ===
> ok
> test_deleteNetwork_user_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 61.766s
> 
> OK
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>


Re: Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

Posted by sangeetha hariharan <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 8:39 p.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Changes
-------

Removed "#" from comments that are already encampassed with in """ block


Repository: cloudstack-git


Description
-------

This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users


Diffs (updated)
-----

  test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22712/diff/


Testing
-------

Test Suite was executed against a management server built from 4.4-forward branch using a simulator set up:
test_deleteNetwork_admin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_forcrossdomainuser (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsubdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : SUCCESS ===
ok
test_deleteNetwork_user (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 10 tests in 61.766s

OK


Thanks,

sangeetha hariharan


Re: Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

Posted by sangeetha hariharan <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/
-----------------------------------------------------------

(Updated Sept. 8, 2014, 7:52 p.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Changes
-------

Moved out the data used by test suite from Sevices object with in the test suite to test_data.py
Changed the tags for test cases - required_hardware="false" to be picked up by simulator runs.


Repository: cloudstack-git


Description
-------

This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users


Diffs (updated)
-----

  test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22712/diff/


Testing (updated)
-------

Test Suite was executed against a management server built from 4.4-forward branch using a simulator set up:
test_deleteNetwork_admin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_forcrossdomainuser (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsubdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : SUCCESS ===
ok
test_deleteNetwork_user (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinotherdomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinsamedomain (integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete) ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 10 tests in 61.766s

OK


Thanks,

sangeetha hariharan