You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dcelasun <gi...@git.apache.org> on 2017/05/11 10:09:20 UTC
[GitHub] thrift pull request #1266: THRIFT-4197 [Go] Transparent gzip support for HTT...
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1266
THRIFT-4197 [Go] Transparent gzip support for HTTP transport
Check if the client supports gzip compressed responses and compress the response if it does.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift go-gzip-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1266
----
commit b148a865bc2c2ade26dcffc0a7b18c85dc332464
Author: D. Can Celasun <ca...@dcc.im>
Date: 2017-05-11T10:04:01Z
[Go] Transparent gzip support for HTTP transport
Check if the client supports gzip compressed responses and compress
the response if it does.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1266
> I have a life besides Thrift, you know ;-)
As do we all :)
> Don't panic
No panic here, or in the code! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1266
Travis failure is unrelated, seems like a Haskell problem:
```
Build log ( /root/.cabal/logs/HUnit-1.6.0.0.log ):
cabal: /root/.cabal/logs/HUnit-1.6.0.0.log: does not exist
lib/hs/CMakeFiles/haskell_library.dir/build.make:88: recipe for target 'lib/hs/thrift_cabal.stamp' failed
make[2]: *** [lib/hs/thrift_cabal.stamp] Error 1
CMakeFiles/Makefile2:3926: recipe for target 'lib/hs/CMakeFiles/haskell_library.dir/all' failed
make[1]: *** [lib/hs/CMakeFiles/haskell_library.dir/all] Error 2
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1266
Don't panic, I already planned to look into this. I have a life besidesThrift, you know ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...
Posted by mrwiggles <gi...@git.apache.org>.
Github user mrwiggles commented on the issue:
https://github.com/apache/thrift/pull/1266
Seems very straightforward. Were you able to test it out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1266: THRIFT-4197 [Go] Transparent gzip support for HTT...
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun closed the pull request at:
https://github.com/apache/thrift/pull/1266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1266: THRIFT-4197 [Go] Transparent gzip support for HTT...
Posted by dcelasun <gi...@git.apache.org>.
GitHub user dcelasun reopened a pull request:
https://github.com/apache/thrift/pull/1266
THRIFT-4197 [Go] Transparent gzip support for HTTP transport
Check if the client supports gzip compressed responses and compress the response if it does.
@Jens-G thoughts?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift go-gzip-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1266
----
commit b434d2d59b98f457600d0928e519b400462dee4a
Author: D. Can Celasun <ca...@dcc.im>
Date: 2017-05-11T10:04:01Z
[Go] Transparent gzip support for HTTP transport
Check if the client supports gzip compressed responses and compress
the response if it does.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1266
Yes I did, works just fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1266: THRIFT-4197 [Go] Transparent gzip support for HTT...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---