[GitHub] [arrow-rs] jhorstmann commented on a diff in pull request #3965: Add Fields abstraction (#3955)

["jhorstmann (via GitHub)" <gi...@apache.org>]

jhorstmann commented on code in PR #3965:
URL: https://github.com/apache/arrow-rs/pull/3965#discussion_r1152326503


##########
arrow-schema/src/datatype.rs:
##########
@@ -182,7 +183,7 @@ pub enum DataType {
     /// A single LargeList array can store up to [`i64::MAX`] elements in total
     LargeList(Box<Field>),

Review Comment:
   Another followup could be done for `Union`, although that would also benefit from a `Vec<(Field, i8)>` instead of two separate vectors. I think that also currently makes it the largest variant, which increases the needed size of all datatypes.
   
   A slightly hacky improvement for union could also be to move the `type_id` into `Field` and leave it unused in most places. That should basically be free since `Field` already has a few bits of padding left.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org