[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1253: support special characters.

[GitBox <gi...@apache.org>]

Ring-k commented on a change in pull request #1253:
URL: https://github.com/apache/incubator-iotdb/pull/1253#discussion_r429631834



##########
File path: docs/UserGuide/5-Operation Manual/4-SQL Reference.md
##########
@@ -32,8 +32,6 @@ All of these statements are write in IoTDB's own syntax, for details about the s
 
 ## Keywords
 
-Please not use these keywords as identifiers.

Review comment:
       It seems that this hint still works. 

##########
File path: server/src/main/antlr4/org/apache/iotdb/db/qp/strategy/SqlBase.g4
##########
@@ -37,7 +37,7 @@ statement
     | CREATE INDEX ON fullPath USING function=ID indexWithClause? whereClause? #createIndex //not support yet
     | DROP INDEX function=ID ON fullPath #dropIndex //not support yet
     | MERGE #merge
-    | FLUSH prefixPath? (COMMA prefixPath)* (ID)?#flush //ID is true or false
+    | FLUSH prefixPath? (COMMA prefixPath)* (booleanClause)?#flush //ID is true or false

Review comment:
       The comment should be updated.

##########
File path: server/src/test/java/org/apache/iotdb/db/qp/plan/PhysicalPlanTest.java
##########
@@ -796,4 +796,11 @@ public void testLastPlanDataTypes() throws QueryProcessException {
       assertEquals(TSDataType.FLOAT, dt);
     }
   }
+
+  @Test
+  public void testSpecialCharacters() throws QueryProcessException {
+    String sqlStr1 = "create timeseries root.3e-3.-1.1/2.SNAPPY.RLE with datatype=FLOAT, encoding=RLE, compression=SNAPPY tags(tag1=v1, tag2=v2) attributes(attr1=v1, attr2=v2)";
+    PhysicalPlan plan1 = processor.parseSQLToPhysicalPlan(sqlStr1);
+    Assert.assertEquals(OperatorType.CREATE_TIMESERIES, plan1.getOperatorType());

Review comment:
       The path in the plan should be checked, not so serious though.

##########
File path: docs/zh/UserGuide/5-Operation Manual/4-SQL Reference.md
##########
@@ -23,8 +23,6 @@
 
 ## 关键字
 
-不要使用这些关键字作为标识符。

Review comment:
       It seems that this hint still works.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org