[GitHub] [iceberg] hailin0 commented on a diff in pull request #4649: Flink 1.14: Implement LookupTableSource for IcebergTableSource

[GitBox <gi...@apache.org>]

hailin0 commented on code in PR #4649:
URL: https://github.com/apache/iceberg/pull/4649#discussion_r864833701


##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSource.java:
##########
@@ -47,7 +55,8 @@
  * Flink Iceberg table source.
  */
 public class IcebergTableSource
-    implements ScanTableSource, SupportsProjectionPushDown, SupportsFilterPushDown, SupportsLimitPushDown {
+    implements ScanTableSource, LookupTableSource, SupportsProjectionPushDown, SupportsFilterPushDown,

Review Comment:
   https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sql/queries/joins/#lookup-join
   
   e.g 
   
   ```
   
   SELECT
   	click_event.*,
   	city_metadata.province,
   	city_metadata.longitude,
   	city_metadata.latitude,
   	user_metadata.NAME,
   	user_metadata.department,
   	user_metadata.age,
   	user_metadata.address,
   	user_metadata.tel,
   	user_metadata.email 
   FROM
   	`click_event`
   	LEFT JOIN `city` FOR SYSTEM_TIME AS OF click_event.proc_time AS `city_metadata` ON click_event.city_name = city_metadata.city_name
   	LEFT JOIN `user` FOR SYSTEM_TIME AS OF click_event.proc_time AS `user_metadata` ON click_event.user_id = user_metadata.id
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org