[jira] [Updated] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

["Kevin Liew (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Liew updated PHOENIX-3413:
--------------------------------
    Attachment: PHOENIX-3413.3.patch

Hopefully those issues have been resolve and it passes this time. [~jamestaylor], please review.

> Ineffective null check in LiteralExpression#newConstant()
> ---------------------------------------------------------
>
>                 Key: PHOENIX-3413
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3413
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.1
>            Reporter: Ted Yu
>            Assignee: Kevin Liew
>            Priority: Minor
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-3413.2.patch, PHOENIX-3413.3.patch, PHOENIX-3413.patch
>
>
> {code}
>         if (maxLength == null) {
>             maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
>         }
> {code}
> The null check for type is ineffective - type is de-referenced in various places prior to the above check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)