You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Raja Aluri (JIRA)" <ji...@apache.org> on 2012/10/25 19:17:13 UTC
[jira] [Created] (SQOOP-651) adding .gitattributes to prevent CRLF
and LF mismatches for source and text files
Raja Aluri created SQOOP-651:
--------------------------------
Summary: adding .gitattributes to prevent CRLF and LF mismatches for source and text files
Key: SQOOP-651
URL: https://issues.apache.org/jira/browse/SQOOP-651
Project: Sqoop
Issue Type: Bug
Components: build
Affects Versions: 1.4.2, 2.0.0
Reporter: Raja Aluri
With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
# http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
# http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
This issue for adding .gitattributes file to the tree.
Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484573#comment-13484573 ]
Hudson commented on SQOOP-651:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop100 #243 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/243/])
SQOOP-651: adding .gitattributes to prevent CRLF and LF mismatches for source and text files (Revision d0645bed54b28bb7a5a3563e563c941ce241f050)
Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d0645bed54b28bb7a5a3563e563c941ce241f050
Files :
* .gitattributes
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.0, 1.4.3
>
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484569#comment-13484569 ]
Hudson commented on SQOOP-651:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop20 #259 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/259/])
SQOOP-651: adding .gitattributes to prevent CRLF and LF mismatches for source and text files (Revision d0645bed54b28bb7a5a3563e563c941ce241f050)
Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d0645bed54b28bb7a5a3563e563c941ce241f050
Files :
* .gitattributes
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.0, 1.4.3
>
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484546#comment-13484546 ]
Jarek Jarcec Cecho commented on SQOOP-651:
------------------------------------------
Committed to trunk: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=d0645bed54b28bb7a5a3563e563c941ce241f050
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484402#comment-13484402 ]
Jarek Jarcec Cecho commented on SQOOP-651:
------------------------------------------
Hi Raja,
thank you for your patch. The changes (after reading documentation) seems reasonable to me. I just have one question - shouldn't we set *.jar to binary as we're having some of them in the repository?
Jarcec
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-651) adding .gitattributes to prevent CRLF
and LF mismatches for source and text files
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated SQOOP-651:
-----------------------------
Attachment: SQOOP-651.patch
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484570#comment-13484570 ]
Hudson commented on SQOOP-651:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop200 #264 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/264/])
SQOOP-651: adding .gitattributes to prevent CRLF and LF mismatches for source and text files (Revision d0645bed54b28bb7a5a3563e563c941ce241f050)
Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d0645bed54b28bb7a5a3563e563c941ce241f050
Files :
* .gitattributes
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.0, 1.4.3
>
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484548#comment-13484548 ]
Jarek Jarcec Cecho commented on SQOOP-651:
------------------------------------------
And cherry-picked to sqoop2 branch: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=11929ae32d87f620a9d6eeda5c4a9acebf00aad7
I'm not planning to do any commit to 1.4.2 branch as we aren't planning to do any release there at the moment (the next planned release is 1.4.3 that will be cut from trunk).
Jarcec
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-651) adding .gitattributes to prevent CRLF
and LF mismatches for source and text files
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated SQOOP-651:
-----------------------------
Attachment: SQOOP-651.patch
Attached new patch with the Apache License information
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-651) adding .gitattributes to prevent CRLF
and LF mismatches for source and text files
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated SQOOP-651:
-----------------------------
Attachment: (was: SQOOP-651.patch)
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SQOOP-651) adding .gitattributes to
prevent CRLF and LF mismatches for source and text files
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484485#comment-13484485 ]
Jarek Jarcec Cecho edited comment on SQOOP-651 at 10/25/12 9:12 PM:
--------------------------------------------------------------------
Thanks for your comment [~raja@cmbasics.com]. It's pretty simple patch so I'll give my +1 here.
Jarcec
was (Author: jarcec):
Thanks for your comment [~raja@cmbasics.com]]. It's pretty simple patch so I'll give my +1 here.
Jarcec
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484488#comment-13484488 ]
Jarek Jarcec Cecho commented on SQOOP-651:
------------------------------------------
Actually I've just realized that I spent too much thinking about technical details and I've completely missed the non technical ones. Your patch is missing Apache header which is unfortunately show stopper for me. Would you mind appending this header and resubmitting your patch again? (feel free to copy&paste the header from .gitignore file).
Jarcec
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484568#comment-13484568 ]
Hudson commented on SQOOP-651:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop23 #398 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/398/])
SQOOP-651: adding .gitattributes to prevent CRLF and LF mismatches for source and text files (Revision d0645bed54b28bb7a5a3563e563c941ce241f050)
Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d0645bed54b28bb7a5a3563e563c941ce241f050
Files :
* .gitattributes
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.0, 1.4.3
>
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484485#comment-13484485 ]
Jarek Jarcec Cecho commented on SQOOP-651:
------------------------------------------
Thanks for your comment [~raja@cmbasics.com]]. It's pretty simple patch so I'll give my +1 here.
Jarcec
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-651) adding .gitattributes to prevent
CRLF and LF mismatches for source and text files
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484459#comment-13484459 ]
Raja Aluri commented on SQOOP-651:
----------------------------------
Hi [~jarcec],
git identifies .jar files as binary and doesn't try to do the line ending transformation. It's only the problem with text files.
Raja
> adding .gitattributes to prevent CRLF and LF mismatches for source and text files
> ---------------------------------------------------------------------------------
>
> Key: SQOOP-651
> URL: https://issues.apache.org/jira/browse/SQOOP-651
> Project: Sqoop
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.2, 2.0.0
> Reporter: Raja Aluri
> Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>
> This issue for adding .gitattributes file to the tree.
> Please refer to [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira