[jira] [Commented] (KAFKA-9625) Unable to Describe broker configurations that have been set via IncrementalAlterConfigs

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055504#comment-17055504 ] 

ASF GitHub Bot commented on KAFKA-9625:
---------------------------------------

skaundinya15 commented on pull request #8260: KAFKA-9625: Fixing IncrementalAlterConfigs with respect to Broker Configs
URL: https://github.com/apache/kafka/pull/8260
 
 
   This PR introduces a bug fix for `IncrementalAlterConfigs` with respect to altering broker configs. Previously broker throttles were incorrectly marked as sensitive configurations. In addition, when trying to delete configs, `DescribeConfigs` would always return the initially deleted configs. This PR fixes both of those issues.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unable to Describe broker configurations that have been set via IncrementalAlterConfigs
> ---------------------------------------------------------------------------------------
>
>                 Key: KAFKA-9625
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9625
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Colin McCabe
>            Assignee: Sanjana Kaundinya
>            Priority: Critical
>             Fix For: 2.6.0
>
>
> There seem to be at least two bugs in the broker configuration APIs and/or logic:
> 1. Broker throttles are incorrectly marked as sensitive configurations.  This includes leader.replication.throttled.rate, follower.replication.throttled.rate, replica.alter.log.dirs.io.max.bytes.per.second.  This means that their values cannot be read back by DescribeConfigs after they are set.
> 2. When we clear the broker throttles via incrementalAlterConfigs, DescribeConfigs continues returning the old throttles indefinitely.  In other words, the clearing is not reflected in the Describe API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)