You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "WireBaron (GitHub)" <gi...@apache.org> on 2018/10/15 23:40:31 UTC
[GitHub] [geode] WireBaron opened pull request #2617: GEODE-5742:
Restrict default membership range to not conflict with default ports
Currently the default range for membership ports is 1024-65535. This results
in occassional failures where a random membership port selection will conflict
with the default server or locator port when using all default values.
This change modifies the default range to 41000-61000. In addition to not
conflicting with any of the default ports (highest is 40404), this is also a
proper subset of the default Linux ephemeral port range (32768-61000).
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2617 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] WireBaron closed pull request #2617: GEODE-5742:
Restrict default membership range to not conflict with default ports
Posted by "WireBaron (GitHub)" <gi...@apache.org>.
[ pull request closed by WireBaron ]
[ Full content available at: https://github.com/apache/geode/pull/2617 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] WireBaron commented on issue #2617: GEODE-5742:
Restrict default membership range to not conflict with default ports
Posted by "WireBaron (GitHub)" <gi...@apache.org>.
Updated the geode-docs for the new range as well as the comment in DistributedSystemConfig. Also updated TCPConduit to take the defaults from DistributionConfig (like it does for other properties).
[ Full content available at: https://github.com/apache/geode/pull/2617 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] WireBaron commented on issue #2617: GEODE-5742:
Restrict default membership range to not conflict with default ports
Posted by "WireBaron (GitHub)" <gi...@apache.org>.
Apparently the main branch was in a somewhat broken state where I branched from originally, just rebased to the latest and did a force-push, so the history might look a bit ugly.
[ Full content available at: https://github.com/apache/geode/pull/2617 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org